Commit f1b3a2a7 authored by Zheng Liu's avatar Zheng Liu Committed by Theodore Ts'o
Browse files

ext4: remove unneeded variable in ext4_xattr_check_block() 



We could return directly from ext4_xattr_check_block(). Thus, we
shouldn't need to define a 'error' variable.

Signed-off-by: default avatarZheng Liu <wenqing.lz@taobao.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent 661aa520

fs/ext4/xattr.c

+1 −4
Original line number Original line Diff line number Diff line
@@ -158,13 +158,10 @@ ext4_xattr_check_names(struct ext4_xattr_entry *entry, void *end) 
static inline int

static inline int

ext4_xattr_check_block(struct buffer_head *bh)

ext4_xattr_check_block(struct buffer_head *bh)

{

{

	int error;



	if (BHDR(bh)->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC) ||

	if (BHDR(bh)->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC) ||

	    BHDR(bh)->h_blocks != cpu_to_le32(1))

	    BHDR(bh)->h_blocks != cpu_to_le32(1))

		return -EIO;

		return -EIO;

	error = ext4_xattr_check_names(BFIRST(bh), bh->b_data + bh->b_size);

	return ext4_xattr_check_names(BFIRST(bh), bh->b_data + bh->b_size);

	return error;

}

}





static inline int

static inline int