Commit f3c8bd46 authored Jan 14, 2019 by Sergey Matyukevich Committed by Kalle Valo Feb 01, 2019

qtnfmac: do not reject retry changes in driver



Do not reject RETRY changes in driver. This decision
should belong to firmware.

Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 9fe504a1

drivers/net/wireless/quantenna/qtnfmac/cfg80211.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -363,11 +363,6 @@ static int qtnf_set_wiphy_params(struct wiphy *wiphy, u32 changed)
		return -EFAULT;
		}

		if (changed & (WIPHY_PARAM_RETRY_LONG \| WIPHY_PARAM_RETRY_SHORT)) {
		pr_err("MAC%u: can't modify retry params\n", mac->macid);
		return -EOPNOTSUPP;
		}

		ret = qtnf_cmd_send_update_phy_params(mac, changed);
		if (ret)
		pr_err("MAC%u: failed to update PHY params\n", mac->macid);

drivers/net/wireless/quantenna/qtnfmac/commands.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -1824,6 +1824,14 @@ int qtnf_cmd_send_update_phy_params(struct qtnf_wmac *mac, u32 changed)
		qtnf_cmd_skb_put_tlv_u8(cmd_skb, QTN_TLV_ID_COVERAGE_CLASS,
		wiphy->coverage_class);

		if (changed & WIPHY_PARAM_RETRY_LONG)
		qtnf_cmd_skb_put_tlv_u8(cmd_skb, QTN_TLV_ID_LRETRY_LIMIT,
		wiphy->retry_long);

		if (changed & WIPHY_PARAM_RETRY_SHORT)
		qtnf_cmd_skb_put_tlv_u8(cmd_skb, QTN_TLV_ID_SRETRY_LIMIT,
		wiphy->retry_short);

		ret = qtnf_cmd_send(mac->bus, cmd_skb);
		if (ret)
		goto out;