Commit f46ac009 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Jonathan Cameron
Browse files

iio: dac: Convert powerdown read callbacks to sysfs_emit() 



Update DAC drivers powerdown attribute show callback to use the new
sysfs_emit() function.

sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it
knows about the sysfs buffer specifics and has some built-in sanity checks.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20210320071405.9347-5-lars@metafoo.de


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 6b92ba0a

drivers/iio/dac/ad5064.c

+1 −1
Original line number Diff line number Diff line
@@ -277,7 +277,7 @@ static ssize_t ad5064_read_dac_powerdown(struct iio_dev *indio_dev, 
{

	struct ad5064_state *st = iio_priv(indio_dev);



	return sprintf(buf, "%d\n", st->pwr_down[chan->channel]);

	return sysfs_emit(buf, "%d\n", st->pwr_down[chan->channel]);

}



static ssize_t ad5064_write_dac_powerdown(struct iio_dev *indio_dev,

drivers/iio/dac/ad5360.c

+1 −1
Original line number Diff line number Diff line
@@ -255,7 +255,7 @@ static ssize_t ad5360_read_dac_powerdown(struct device *dev, 
	struct iio_dev *indio_dev = dev_to_iio_dev(dev);

	struct ad5360_state *st = iio_priv(indio_dev);



	return sprintf(buf, "%d\n", (bool)(st->ctrl & AD5360_SF_CTRL_PWR_DOWN));

	return sysfs_emit(buf, "%d\n", (bool)(st->ctrl & AD5360_SF_CTRL_PWR_DOWN));

}



static int ad5360_update_ctrl(struct iio_dev *indio_dev, unsigned int set,

drivers/iio/dac/ad5380.c

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ static ssize_t ad5380_read_dac_powerdown(struct iio_dev *indio_dev, 
{

	struct ad5380_state *st = iio_priv(indio_dev);



	return sprintf(buf, "%d\n", st->pwr_down);

	return sysfs_emit(buf, "%d\n", st->pwr_down);

}



static ssize_t ad5380_write_dac_powerdown(struct iio_dev *indio_dev,

drivers/iio/dac/ad5446.c

+1 −1
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ static ssize_t ad5446_read_dac_powerdown(struct iio_dev *indio_dev, 
{

	struct ad5446_state *st = iio_priv(indio_dev);



	return sprintf(buf, "%d\n", st->pwr_down);

	return sysfs_emit(buf, "%d\n", st->pwr_down);

}



static ssize_t ad5446_write_dac_powerdown(struct iio_dev *indio_dev,

drivers/iio/dac/ad5504.c

+2 −2
Original line number Diff line number Diff line
@@ -170,7 +170,7 @@ static ssize_t ad5504_read_dac_powerdown(struct iio_dev *indio_dev, 
{

	struct ad5504_state *st = iio_priv(indio_dev);



	return sprintf(buf, "%d\n",

	return sysfs_emit(buf, "%d\n",

			  !(st->pwr_down_mask & (1 << chan->channel)));

}