Commit f4eddf1d authored by Kalyan Thota's avatar Kalyan Thota Committed by Dmitry Baryshkov
Browse files

drm/msm/dpu: avoid unnecessary check in DPU reservations 



Return immediately on failure, this will make dpu reservations
part look cleaner.

Signed-off-by: default avatarKalyan Thota <quic_kalyant@quicinc.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarMarijn Suijten <marijn.suijten@somainline.org>
Patchwork: https://patchwork.freedesktop.org/patch/522442/
Link: https://lore.kernel.org/r/1676286704-818-4-git-send-email-quic_kalyant@quicinc.com


[DB: fixed merge conflict with b6975693, retain those changes]
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent 8aa22aaa

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

+10 −13
Original line number Diff line number Diff line
@@ -635,14 +635,12 @@ static int dpu_encoder_virt_atomic_check( 
		if (ret) {

			DPU_ERROR_ENC(dpu_enc,

					"mode unsupported, phys idx %d\n", i);

			break;

			return ret;

		}

	}



	topology = dpu_encoder_get_topology(dpu_enc, dpu_kms, adj_mode, crtc_state);



	/* Reserve dynamic resources now. */

	if (!ret) {

	/*

	 * Release and Allocate resources on every modeset

	 * Dont allocate when active is false.
@@ -654,7 +652,6 @@ static int dpu_encoder_virt_atomic_check( 
			ret = dpu_rm_reserve(&dpu_kms->rm, global_state,

					drm_enc, crtc_state, topology);

	}

	}



	trace_dpu_enc_atomic_check_flags(DRMID(drm_enc), adj_mode->flags);