Commit f6d47fe5 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Greg Kroah-Hartman
Browse files

usb: serial: Make ->set_termios() old ktermios const 



There should be no reason to adjust old ktermios which is going to get
discarded anyway.

Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20220816115739.10928-8-ilpo.jarvinen@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bec5b814

drivers/usb/serial/ark3116.c

+1 −1
Original line number Diff line number Diff line
@@ -189,7 +189,7 @@ static void ark3116_port_remove(struct usb_serial_port *port) 


static void ark3116_set_termios(struct tty_struct *tty,

				struct usb_serial_port *port,

				struct ktermios *old_termios)

				const struct ktermios *old_termios)

{

	struct usb_serial *serial = port->serial;

	struct ark3116_private *priv = usb_get_serial_port_data(port);

drivers/usb/serial/belkin_sa.c

+4 −2
Original line number Diff line number Diff line
@@ -44,7 +44,8 @@ static void belkin_sa_close(struct usb_serial_port *port); 
static void belkin_sa_read_int_callback(struct urb *urb);

static void belkin_sa_process_read_urb(struct urb *urb);

static void belkin_sa_set_termios(struct tty_struct *tty,

			struct usb_serial_port *port, struct ktermios * old);

				  struct usb_serial_port *port,

				  const struct ktermios *old_termios);

static void belkin_sa_break_ctl(struct tty_struct *tty, int break_state);

static int  belkin_sa_tiocmget(struct tty_struct *tty);

static int  belkin_sa_tiocmset(struct tty_struct *tty,
@@ -273,7 +274,8 @@ static void belkin_sa_process_read_urb(struct urb *urb) 
}



static void belkin_sa_set_termios(struct tty_struct *tty,

		struct usb_serial_port *port, struct ktermios *old_termios)

				  struct usb_serial_port *port,

				  const struct ktermios *old_termios)

{

	struct usb_serial *serial = port->serial;

	struct belkin_sa_private *priv = usb_get_serial_port_data(port);

drivers/usb/serial/ch341.c

+3 −2
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ struct ch341_private { 


static void ch341_set_termios(struct tty_struct *tty,

			      struct usb_serial_port *port,

			      struct ktermios *old_termios);

			      const struct ktermios *old_termios);



static int ch341_control_out(struct usb_device *dev, u8 request,

			     u16 value, u16 index)
@@ -470,7 +470,8 @@ static int ch341_open(struct tty_struct *tty, struct usb_serial_port *port) 
 * tty->termios contains the new setting to be used.

 */

static void ch341_set_termios(struct tty_struct *tty,

		struct usb_serial_port *port, struct ktermios *old_termios)

			      struct usb_serial_port *port,

			      const struct ktermios *old_termios)

{

	struct ch341_private *priv = usb_get_serial_port_data(port);

	unsigned baud_rate;

drivers/usb/serial/cp210x.c

+8 −5
Original line number Diff line number Diff line
@@ -31,9 +31,9 @@ 
static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *);

static void cp210x_close(struct usb_serial_port *);

static void cp210x_change_speed(struct tty_struct *, struct usb_serial_port *,

							struct ktermios *);

				const struct ktermios *);

static void cp210x_set_termios(struct tty_struct *, struct usb_serial_port *,

							struct ktermios*);

			       const struct ktermios *);

static bool cp210x_tx_empty(struct usb_serial_port *port);

static int cp210x_tiocmget(struct tty_struct *);

static int cp210x_tiocmset(struct tty_struct *, unsigned int, unsigned int);
@@ -1039,7 +1039,8 @@ static speed_t cp210x_get_actual_rate(speed_t baud) 
 * otherwise.

 */

static void cp210x_change_speed(struct tty_struct *tty,

		struct usb_serial_port *port, struct ktermios *old_termios)

				struct usb_serial_port *port,

				const struct ktermios *old_termios)

{

	struct usb_serial *serial = port->serial;

	struct cp210x_serial_private *priv = usb_get_serial_data(serial);
@@ -1121,7 +1122,8 @@ static bool cp210x_termios_change(const struct ktermios *a, const struct ktermio 
}



static void cp210x_set_flow_control(struct tty_struct *tty,

		struct usb_serial_port *port, struct ktermios *old_termios)

				    struct usb_serial_port *port,

				    const struct ktermios *old_termios)

{

	struct cp210x_serial_private *priv = usb_get_serial_data(port->serial);

	struct cp210x_port_private *port_priv = usb_get_serial_port_data(port);
@@ -1231,7 +1233,8 @@ static void cp210x_set_flow_control(struct tty_struct *tty, 
}



static void cp210x_set_termios(struct tty_struct *tty,

		struct usb_serial_port *port, struct ktermios *old_termios)

		               struct usb_serial_port *port,

		               const struct ktermios *old_termios)

{

	struct cp210x_serial_private *priv = usb_get_serial_data(port->serial);

	u16 bits;

drivers/usb/serial/cypress_m8.c

+4 −2
Original line number Diff line number Diff line
@@ -125,7 +125,8 @@ static void cypress_send(struct usb_serial_port *port); 
static unsigned int cypress_write_room(struct tty_struct *tty);

static void cypress_earthmate_init_termios(struct tty_struct *tty);

static void cypress_set_termios(struct tty_struct *tty,

			struct usb_serial_port *port, struct ktermios *old);

				struct usb_serial_port *port,

				const struct ktermios *old_termios);

static int  cypress_tiocmget(struct tty_struct *tty);

static int  cypress_tiocmset(struct tty_struct *tty,

			unsigned int set, unsigned int clear);
@@ -859,7 +860,8 @@ static void cypress_earthmate_init_termios(struct tty_struct *tty) 
}



static void cypress_set_termios(struct tty_struct *tty,

	struct usb_serial_port *port, struct ktermios *old_termios)

				struct usb_serial_port *port,

				const struct ktermios *old_termios)

{

	struct cypress_private *priv = usb_get_serial_port_data(port);

	struct device *dev = &port->dev;