Commit f748f34e authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Vinod Koul
Browse files

soundwire: intel: add error log for clock-stop invalid configs 



Detect cases where the clock is assumed to be stopped but the IP is
not in the relevant state. There is no real way to recover here, but
adding an error log can help detect bad programming sequences or race
conditions.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20200901150556.19432-9-yung-chuan.liao@linux.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 063ff4e5

drivers/soundwire/intel.c

+5 −0
Original line number Diff line number Diff line
@@ -1931,6 +1931,11 @@ static int intel_resume_runtime(struct device *dev) 
			}

		}

	} else if (!clock_stop_quirks) {



		clock_stop0 = sdw_cdns_is_clock_stop(&sdw->cdns);

		if (!clock_stop0)

			dev_err(dev, "%s invalid configuration, clock was not stopped", __func__);



		ret = intel_init(sdw);

		if (ret) {

			dev_err(dev, "%s failed: %d", __func__, ret);