Commit f7d85105 authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: remove all DBG_88E calls from os_dep/rtw_android.c 



Remove all DBG_88E calls from os_dep/rtw_android.c as this macro is
unnecessary, and many of these calls are dubious in terms of necessity.
Removing all calls will ultimately allow the removal of the macro
itself.

Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210615001507.1171-17-phil@philpotter.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent de771188

drivers/staging/rtl8188eu/os_dep/rtw_android.c

+3 −12
Original line number Diff line number Diff line
@@ -135,8 +135,6 @@ int rtw_android_priv_cmd(struct net_device *net, struct ifreq *ifr, int cmd) 
	if (IS_ERR(command))

		return PTR_ERR(command);

	command[priv_cmd.total_len - 1] = 0;

	DBG_88E("%s: Android private cmd \"%s\" on %s\n",

		__func__, command, ifr->ifr_name);

	cmd_num = rtw_android_cmdstr_to_num(command);

	switch (cmd_num) {

	case ANDROID_WIFI_CMD_START:
@@ -202,7 +200,6 @@ int rtw_android_priv_cmd(struct net_device *net, struct ifreq *ifr, int cmd) 
	case ANDROID_WIFI_CMD_P2P_SET_PS:

		break;

	default:

		DBG_88E("Unknown PRIVATE command %s - ignored\n", command);

		snprintf(command, 3, "OK");

		bytes_written = strlen("OK");

	}
@@ -211,20 +208,14 @@ int rtw_android_priv_cmd(struct net_device *net, struct ifreq *ifr, int cmd) 
	if (bytes_written >= 0) {

		if ((bytes_written == 0) && (priv_cmd.total_len > 0))

			command[0] = '\0';

		if (bytes_written >= priv_cmd.total_len) {

			DBG_88E("%s: bytes_written = %d\n", __func__,

				bytes_written);

		if (bytes_written >= priv_cmd.total_len)

			bytes_written = priv_cmd.total_len;

		} else {

		else

			bytes_written++;

		}

		priv_cmd.used_len = bytes_written;

		if (copy_to_user((char __user *)priv_cmd.buf, command,

				 bytes_written)) {

			DBG_88E("%s: failed to copy data to user buffer\n",

				__func__);

				 bytes_written))

			ret = -EFAULT;

		}

	} else {

		ret = bytes_written;

	}