Commit f95a29d4 authored by Jérôme Pouiller's avatar Jérôme Pouiller Committed by Greg Kroah-Hartman
Browse files

staging: wfx: add HIF commands helpers 



Provide an abstraction for HIF commands.

Signed-off-by: default avatarJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20190919142527.31797-13-Jerome.Pouiller@silabs.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4f8b7fab

drivers/staging/wfx/hif_tx.c

+375 −0
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 
#include "hif_tx.h"

#include "wfx.h"

#include "bh.h"

#include "hwio.h"

#include "debug.h"



void wfx_init_hif_cmd(struct wfx_hif_cmd *hif_cmd)
@@ -21,6 +22,29 @@ void wfx_init_hif_cmd(struct wfx_hif_cmd *hif_cmd) 
	mutex_init(&hif_cmd->lock);

}



static void wfx_fill_header(struct hif_msg *hif, int if_id, unsigned int cmd, size_t size)

{

	if (if_id == -1)

		if_id = 2;



	WARN(cmd > 0x3f, "invalid WSM command %#.2x", cmd);

	WARN(size > 0xFFF, "requested buffer is too large: %zu bytes", size);

	WARN(if_id > 0x3, "invalid interface ID %d", if_id);



	hif->len = cpu_to_le16(size + 4);

	hif->id = cmd;

	hif->interface = if_id;

}



static void *wfx_alloc_hif(size_t body_len, struct hif_msg **hif)

{

	*hif = kzalloc(sizeof(struct hif_msg) + body_len, GFP_KERNEL);

	if (*hif)

		return (*hif)->body;

	else

		return NULL;

}



int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request, void *reply, size_t reply_len, bool async)

{

	const char *mib_name = "";
@@ -85,3 +109,354 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request, void *reply, siz 


	return ret;

}



// This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any

// request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be

// carefull to only call this funcion during device unregister.

int hif_shutdown(struct wfx_dev *wdev)

{

	int ret;

	struct hif_msg *hif;



	wfx_alloc_hif(0, &hif);

	wfx_fill_header(hif, -1, HIF_REQ_ID_SHUT_DOWN, 0);

	ret = wfx_cmd_send(wdev, hif, NULL, 0, true);

	// After this command, chip won't reply. Be sure to give enough time to

	// bh to send buffer:

	msleep(100);

	wdev->hif_cmd.buf_send = NULL;

	if (wdev->pdata.gpio_wakeup)

		gpiod_set_value(wdev->pdata.gpio_wakeup, 0);

	else

		control_reg_write(wdev, 0);

	mutex_unlock(&wdev->hif_cmd.lock);

	kfree(hif);

	return ret;

}



int hif_configuration(struct wfx_dev *wdev, const u8 *conf, size_t len)

{

	int ret;

	size_t buf_len = sizeof(struct hif_req_configuration) + len;

	struct hif_msg *hif;

	struct hif_req_configuration *body = wfx_alloc_hif(buf_len, &hif);



	body->length = cpu_to_le16(len);

	memcpy(body->pds_data, conf, len);

	wfx_fill_header(hif, -1, HIF_REQ_ID_CONFIGURATION, buf_len);

	ret = wfx_cmd_send(wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_reset(struct wfx_vif *wvif, bool reset_stat)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_reset *body = wfx_alloc_hif(sizeof(*body), &hif);



	body->reset_flags.reset_stat = reset_stat;

	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_RESET, sizeof(*body));

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_read_mib(struct wfx_dev *wdev, int vif_id, u16 mib_id, void *val, size_t val_len)

{

	int ret;

	struct hif_msg *hif;

	int buf_len = sizeof(struct hif_cnf_read_mib) + val_len;

	struct hif_req_read_mib *body = wfx_alloc_hif(sizeof(*body), &hif);

	struct hif_cnf_read_mib *reply = kmalloc(buf_len, GFP_KERNEL);



	body->mib_id = cpu_to_le16(mib_id);

	wfx_fill_header(hif, vif_id, HIF_REQ_ID_READ_MIB, sizeof(*body));

	ret = wfx_cmd_send(wdev, hif, reply, buf_len, false);



	if (!ret && mib_id != reply->mib_id) {

		dev_warn(wdev->dev, "%s: confirmation mismatch request\n", __func__);

		ret = -EIO;

	}

	if (ret == -ENOMEM)

		dev_err(wdev->dev, "buffer is too small to receive %s (%zu < %d)\n",

			get_mib_name(mib_id), val_len, reply->length);

	if (!ret)

		memcpy(val, &reply->mib_data, reply->length);

	else

		memset(val, 0xFF, val_len);

	kfree(hif);

	kfree(reply);

	return ret;

}



int hif_write_mib(struct wfx_dev *wdev, int vif_id, u16 mib_id, void *val, size_t val_len)

{

	int ret;

	struct hif_msg *hif;

	int buf_len = sizeof(struct hif_req_write_mib) + val_len;

	struct hif_req_write_mib *body = wfx_alloc_hif(buf_len, &hif);



	body->mib_id = cpu_to_le16(mib_id);

	body->length = cpu_to_le16(val_len);

	memcpy(&body->mib_data, val, val_len);

	wfx_fill_header(hif, vif_id, HIF_REQ_ID_WRITE_MIB, buf_len);

	ret = wfx_cmd_send(wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_scan(struct wfx_vif *wvif, const struct wfx_scan_params *arg)

{

	int ret, i;

	struct hif_msg *hif;

	struct hif_ssid_def *ssids;

	size_t buf_len = sizeof(struct hif_req_start_scan) +

		arg->scan_req.num_of_channels * sizeof(u8) +

		arg->scan_req.num_of_ssi_ds * sizeof(struct hif_ssid_def);

	struct hif_req_start_scan *body = wfx_alloc_hif(buf_len, &hif);

	u8 *ptr = (u8 *) body + sizeof(*body);



	WARN(arg->scan_req.num_of_channels > HIF_API_MAX_NB_CHANNELS, "invalid params");

	WARN(arg->scan_req.num_of_ssi_ds > 2, "invalid params");

	WARN(arg->scan_req.band > 1, "invalid params");



	// FIXME: This API is unnecessary complex, fixing NumOfChannels and

	// adding a member SsidDef at end of struct hif_req_start_scan would

	// simplify that a lot.

	memcpy(body, &arg->scan_req, sizeof(*body));

	cpu_to_le32s(&body->min_channel_time);

	cpu_to_le32s(&body->max_channel_time);

	cpu_to_le32s(&body->tx_power_level);

	memcpy(ptr, arg->ssids, arg->scan_req.num_of_ssi_ds * sizeof(struct hif_ssid_def));

	ssids = (struct hif_ssid_def *) ptr;

	for (i = 0; i < body->num_of_ssi_ds; ++i)

		cpu_to_le32s(&ssids[i].ssid_length);

	ptr += arg->scan_req.num_of_ssi_ds * sizeof(struct hif_ssid_def);

	memcpy(ptr, arg->ch, arg->scan_req.num_of_channels * sizeof(u8));

	ptr += arg->scan_req.num_of_channels * sizeof(u8);

	WARN(buf_len != ptr - (u8 *) body, "allocation size mismatch");

	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_START_SCAN, buf_len);

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_stop_scan(struct wfx_vif *wvif)

{

	int ret;

	struct hif_msg *hif;

	// body associated to HIF_REQ_ID_STOP_SCAN is empty

	wfx_alloc_hif(0, &hif);



	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_STOP_SCAN, 0);

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_join(struct wfx_vif *wvif, const struct hif_req_join *arg)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_join *body = wfx_alloc_hif(sizeof(*body), &hif);



	memcpy(body, arg, sizeof(struct hif_req_join));

	cpu_to_le16s(&body->channel_number);

	cpu_to_le16s(&body->atim_window);

	cpu_to_le32s(&body->ssid_length);

	cpu_to_le32s(&body->beacon_interval);

	cpu_to_le32s(&body->basic_rate_set);

	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_JOIN, sizeof(*body));

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_set_bss_params(struct wfx_vif *wvif, const struct hif_req_set_bss_params *arg)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_set_bss_params *body = wfx_alloc_hif(sizeof(*body), &hif);



	memcpy(body, arg, sizeof(*body));

	cpu_to_le16s(&body->aid);

	cpu_to_le32s(&body->operational_rate_set);

	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_SET_BSS_PARAMS, sizeof(*body));

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_add_key(struct wfx_dev *wdev, const struct hif_req_add_key *arg)

{

	int ret;

	struct hif_msg *hif;

	// FIXME: only send necessary bits

	struct hif_req_add_key *body = wfx_alloc_hif(sizeof(*body), &hif);



	// FIXME: swap bytes as necessary in body

	memcpy(body, arg, sizeof(*body));

	if (wfx_api_older_than(wdev, 1, 5))

		// Legacy firmwares expect that add_key to be sent on right

		// interface.

		wfx_fill_header(hif, arg->int_id, HIF_REQ_ID_ADD_KEY, sizeof(*body));

	else

		wfx_fill_header(hif, -1, HIF_REQ_ID_ADD_KEY, sizeof(*body));

	ret = wfx_cmd_send(wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_remove_key(struct wfx_dev *wdev, int idx)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_remove_key *body = wfx_alloc_hif(sizeof(*body), &hif);



	body->entry_index = idx;

	wfx_fill_header(hif, -1, HIF_REQ_ID_REMOVE_KEY, sizeof(*body));

	ret = wfx_cmd_send(wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_set_edca_queue_params(struct wfx_vif *wvif, const struct hif_req_edca_queue_params *arg)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_edca_queue_params *body = wfx_alloc_hif(sizeof(*body), &hif);



	// NOTE: queues numerotation are not the same between WFx and Linux

	memcpy(body, arg, sizeof(*body));

	cpu_to_le16s(&body->cw_min);

	cpu_to_le16s(&body->cw_max);

	cpu_to_le16s(&body->tx_op_limit);

	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_EDCA_QUEUE_PARAMS, sizeof(*body));

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_set_pm(struct wfx_vif *wvif, const struct hif_req_set_pm_mode *arg)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_set_pm_mode *body = wfx_alloc_hif(sizeof(*body), &hif);



	memcpy(body, arg, sizeof(*body));

	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_SET_PM_MODE, sizeof(*body));

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_start(struct wfx_vif *wvif, const struct hif_req_start *arg)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_start *body = wfx_alloc_hif(sizeof(*body), &hif);



	memcpy(body, arg, sizeof(*body));

	cpu_to_le16s(&body->channel_number);

	cpu_to_le32s(&body->beacon_interval);

	cpu_to_le32s(&body->basic_rate_set);

	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_START, sizeof(*body));

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_beacon_transmit(struct wfx_vif *wvif, bool enable_beaconing)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_beacon_transmit *body = wfx_alloc_hif(sizeof(*body), &hif);



	body->enable_beaconing = enable_beaconing ? 1 : 0;

	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_BEACON_TRANSMIT, sizeof(*body));

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_map_link(struct wfx_vif *wvif, u8 *mac_addr, int flags, int sta_id)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_map_link *body = wfx_alloc_hif(sizeof(*body), &hif);



	if (mac_addr)

		ether_addr_copy(body->mac_addr, mac_addr);

	body->map_link_flags = *(struct hif_map_link_flags *) &flags;

	body->peer_sta_id = sta_id;

	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_MAP_LINK, sizeof(*body));

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_update_ie(struct wfx_vif *wvif, const struct hif_ie_flags *target_frame,

		  const u8 *ies, size_t ies_len)

{

	int ret;

	struct hif_msg *hif;

	int buf_len = sizeof(struct hif_req_update_ie) + ies_len;

	struct hif_req_update_ie *body = wfx_alloc_hif(buf_len, &hif);



	memcpy(&body->ie_flags, target_frame, sizeof(struct hif_ie_flags));

	body->num_i_es = cpu_to_le16(1);

	memcpy(body->ie, ies, ies_len);

	wfx_fill_header(hif, wvif->id, HIF_REQ_ID_UPDATE_IE, buf_len);

	ret = wfx_cmd_send(wvif->wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_sl_send_pub_keys(struct wfx_dev *wdev, const uint8_t *pubkey, const uint8_t *pubkey_hmac)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_sl_exchange_pub_keys *body = wfx_alloc_hif(sizeof(*body), &hif);



	body->algorithm = HIF_SL_CURVE25519;

	memcpy(body->host_pub_key, pubkey, sizeof(body->host_pub_key));

	memcpy(body->host_pub_key_mac, pubkey_hmac, sizeof(body->host_pub_key_mac));

	wfx_fill_header(hif, -1, HIF_REQ_ID_SL_EXCHANGE_PUB_KEYS, sizeof(*body));

	ret = wfx_cmd_send(wdev, hif, NULL, 0, false);

	kfree(hif);

	// Compatibility with legacy secure link

	if (ret == SL_PUB_KEY_EXCHANGE_STATUS_SUCCESS)

		ret = 0;

	return ret;

}



int hif_sl_config(struct wfx_dev *wdev, const unsigned long *bitmap)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_sl_configure *body = wfx_alloc_hif(sizeof(*body), &hif);



	memcpy(body->encr_bmp, bitmap, sizeof(body->encr_bmp));

	wfx_fill_header(hif, -1, HIF_REQ_ID_SL_CONFIGURE, sizeof(*body));

	ret = wfx_cmd_send(wdev, hif, NULL, 0, false);

	kfree(hif);

	return ret;

}



int hif_sl_set_mac_key(struct wfx_dev *wdev, const uint8_t *slk_key, int destination)

{

	int ret;

	struct hif_msg *hif;

	struct hif_req_set_sl_mac_key *body = wfx_alloc_hif(sizeof(*body), &hif);



	memcpy(body->key_value, slk_key, sizeof(body->key_value));

	body->otp_or_ram = destination;

	wfx_fill_header(hif, -1, HIF_REQ_ID_SET_SL_MAC_KEY, sizeof(*body));

	ret = wfx_cmd_send(wdev, hif, NULL, 0, false);

	kfree(hif);

	// Compatibility with legacy secure link

	if (ret == SL_MAC_KEY_STATUS_SUCCESS)

		ret = 0;

	return ret;

}

drivers/staging/wfx/hif_tx.h

+33 −0
Original line number Diff line number Diff line
@@ -15,6 +15,12 @@ 
struct wfx_dev;

struct wfx_vif;



struct wfx_scan_params {

	struct hif_req_start_scan scan_req;

	struct hif_ssid_def *ssids;

	uint8_t *ch;

};



struct wfx_hif_cmd {

	struct mutex      lock;

	struct completion ready;
@@ -30,4 +36,31 @@ void wfx_init_hif_cmd(struct wfx_hif_cmd *wfx_hif_cmd); 
int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,

		 void *reply, size_t reply_len, bool async);



int hif_shutdown(struct wfx_dev *wdev);

int hif_configuration(struct wfx_dev *wdev, const u8 *conf, size_t len);

int hif_reset(struct wfx_vif *wvif, bool reset_stat);

int hif_read_mib(struct wfx_dev *wdev, int vif_id, u16 mib_id,

		 void *buf, size_t buf_size);

int hif_write_mib(struct wfx_dev *wdev, int vif_id, u16 mib_id,

		  void *buf, size_t buf_size);

int hif_scan(struct wfx_vif *wvif, const struct wfx_scan_params *arg);

int hif_stop_scan(struct wfx_vif *wvif);

int hif_join(struct wfx_vif *wvif, const struct hif_req_join *arg);

int hif_set_pm(struct wfx_vif *wvif, const struct hif_req_set_pm_mode *arg);

int hif_set_bss_params(struct wfx_vif *wvif,

		       const struct hif_req_set_bss_params *arg);

int hif_add_key(struct wfx_dev *wdev, const struct hif_req_add_key *arg);

int hif_remove_key(struct wfx_dev *wdev, int idx);

int hif_set_edca_queue_params(struct wfx_vif *wvif,

			      const struct hif_req_edca_queue_params *arg);

int hif_start(struct wfx_vif *wvif, const struct hif_req_start *arg);

int hif_beacon_transmit(struct wfx_vif *wvif, bool enable);

int hif_map_link(struct wfx_vif *wvif, u8 *mac_addr, int flags, int sta_id);

int hif_update_ie(struct wfx_vif *wvif, const struct hif_ie_flags *target_frame,

		  const u8 *ies, size_t ies_len);

int hif_sl_set_mac_key(struct wfx_dev *wdev, const uint8_t *slk_key, int destination);

int hif_sl_config(struct wfx_dev *wdev, const unsigned long *bitmap);

int hif_sl_send_pub_keys(struct wfx_dev *wdev,

			 const uint8_t *pubkey, const uint8_t *pubkey_hmac);



#endif

drivers/staging/wfx/hif_tx_mib.h

0 → 100644
+281 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0-only */

/*

 * Implementation of host-to-chip MIBs of WFxxx Split Mac (WSM) API.

 *

 * Copyright (c) 2017-2019, Silicon Laboratories, Inc.

 * Copyright (c) 2010, ST-Ericsson

 * Copyright (C) 2010, ST-Ericsson SA

 */

#ifndef WFX_HIF_TX_MIB_H

#define WFX_HIF_TX_MIB_H



#include <linux/etherdevice.h>



#include "wfx.h"

#include "hif_tx.h"

#include "hif_api_mib.h"



static inline int hif_set_output_power(struct wfx_vif *wvif, int power_level)

{

	__le32 val = cpu_to_le32(power_level);



	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_CURRENT_TX_POWER_LEVEL,

			     &val, sizeof(val));

}



static inline int hif_set_beacon_wakeup_period(struct wfx_vif *wvif,

					       unsigned int dtim_interval,

					       unsigned int listen_interval)

{

	struct hif_mib_beacon_wake_up_period val = {

		.wakeup_period_min = dtim_interval,

		.receive_dtim = 0,

		.wakeup_period_max = cpu_to_le16(listen_interval),

	};



	if (dtim_interval > 0xFF || listen_interval > 0xFFFF)

		return -EINVAL;

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_BEACON_WAKEUP_PERIOD,

			     &val, sizeof(val));

}



static inline int hif_set_rcpi_rssi_threshold(struct wfx_vif *wvif,

					      struct hif_mib_rcpi_rssi_threshold *arg)

{

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_RCPI_RSSI_THRESHOLD, arg, sizeof(*arg));

}



static inline int hif_get_counters_table(struct wfx_dev *wdev,

					 struct hif_mib_extended_count_table *arg)

{

	if (wfx_api_older_than(wdev, 1, 3)) {

		// extended_count_table is wider than count_table

		memset(arg, 0xFF, sizeof(*arg));

		return hif_read_mib(wdev, 0, HIF_MIB_ID_COUNTERS_TABLE,

				    arg, sizeof(struct hif_mib_count_table));

	} else {

		return hif_read_mib(wdev, 0, HIF_MIB_ID_EXTENDED_COUNTERS_TABLE,

				    arg, sizeof(struct hif_mib_extended_count_table));

	}

}



static inline int hif_set_macaddr(struct wfx_vif *wvif, u8 *mac)

{

	struct hif_mib_mac_address msg = { };



	if (mac)

		ether_addr_copy(msg.mac_addr, mac);

	return hif_write_mib(wvif->wdev, wvif->id, HIF_MIB_ID_DOT11_MAC_ADDRESS,

			     &msg, sizeof(msg));

}



static inline int hif_set_rx_filter(struct wfx_vif *wvif, bool filter_bssid,

				    bool fwd_probe_req)

{

	struct hif_mib_rx_filter val = { };



	if (filter_bssid)

		val.bssid_filter = 1;

	if (fwd_probe_req)

		val.fwd_probe_req = 1;

	return hif_write_mib(wvif->wdev, wvif->id, HIF_MIB_ID_RX_FILTER,

			     &val, sizeof(val));

}



static inline int hif_set_beacon_filter_table(struct wfx_vif *wvif,

					      struct hif_mib_bcn_filter_table *ft)

{

	size_t buf_len = struct_size(ft, ie_table, ft->num_of_info_elmts);



	cpu_to_le32s(&ft->num_of_info_elmts);

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_BEACON_FILTER_TABLE, ft, buf_len);

}



static inline int hif_beacon_filter_control(struct wfx_vif *wvif,

					    int enable, int beacon_count)

{

	struct hif_mib_bcn_filter_enable arg = {

		.enable = cpu_to_le32(enable),

		.bcn_count = cpu_to_le32(beacon_count),

	};

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_BEACON_FILTER_ENABLE, &arg, sizeof(arg));

}



static inline int hif_set_operational_mode(struct wfx_dev *wdev,

					   enum hif_op_power_mode mode)

{

	struct hif_mib_gl_operational_power_mode val = {

		.power_mode = mode,

		.wup_ind_activation = 1,

	};



	return hif_write_mib(wdev, -1, HIF_MIB_ID_GL_OPERATIONAL_POWER_MODE,

			     &val, sizeof(val));

}



static inline int hif_set_template_frame(struct wfx_vif *wvif,

					 struct hif_mib_template_frame *arg)

{

	return hif_write_mib(wvif->wdev, wvif->id, HIF_MIB_ID_TEMPLATE_FRAME,

			     arg, sizeof(*arg));

}



static inline int hif_set_mfp(struct wfx_vif *wvif, bool capable, bool required)

{

	struct hif_mib_protected_mgmt_policy val = { };



	WARN_ON(required && !capable);

	if (capable) {

		val.pmf_enable = 1;

		val.host_enc_auth_frames = 1;

	}

	if (!required)

		val.unpmf_allowed = 1;

	cpu_to_le32s(&val);

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_PROTECTED_MGMT_POLICY,

			     &val, sizeof(val));

}



static inline int hif_set_block_ack_policy(struct wfx_vif *wvif,

					   u8 tx_tid_policy, u8 rx_tid_policy)

{

	struct hif_mib_block_ack_policy val = {

		.block_ack_tx_tid_policy = tx_tid_policy,

		.block_ack_rx_tid_policy = rx_tid_policy,

	};



	return hif_write_mib(wvif->wdev, wvif->id, HIF_MIB_ID_BLOCK_ACK_POLICY,

			     &val, sizeof(val));

}



static inline int hif_set_association_mode(struct wfx_vif *wvif,

					   struct hif_mib_set_association_mode *arg)

{

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_SET_ASSOCIATION_MODE, arg, sizeof(*arg));

}



static inline int hif_set_tx_rate_retry_policy(struct wfx_vif *wvif,

					       struct hif_mib_set_tx_rate_retry_policy *arg)

{

	size_t size = struct_size(arg, tx_rate_retry_policy, arg->num_tx_rate_policies);



	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_SET_TX_RATE_RETRY_POLICY, arg, size);

}



static inline int hif_set_mac_addr_condition(struct wfx_vif *wvif,

					     struct hif_mib_mac_addr_data_frame_condition *arg)

{

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_MAC_ADDR_DATAFRAME_CONDITION,

			     arg, sizeof(*arg));

}



static inline int hif_set_uc_mc_bc_condition(struct wfx_vif *wvif,

					     struct hif_mib_uc_mc_bc_data_frame_condition *arg)

{

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_UC_MC_BC_DATAFRAME_CONDITION,

			     arg, sizeof(*arg));

}



static inline int hif_set_config_data_filter(struct wfx_vif *wvif,

					     struct hif_mib_config_data_filter *arg)

{

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_CONFIG_DATA_FILTER, arg, sizeof(*arg));

}



static inline int hif_set_data_filtering(struct wfx_vif *wvif,

					 struct hif_mib_set_data_filtering *arg)

{

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_SET_DATA_FILTERING, arg, sizeof(*arg));

}



static inline int hif_keep_alive_period(struct wfx_vif *wvif, int period)

{

	struct hif_mib_keep_alive_period arg = {

		.keep_alive_period = cpu_to_le16(period),

	};



	return hif_write_mib(wvif->wdev, wvif->id, HIF_MIB_ID_KEEP_ALIVE_PERIOD,

			     &arg, sizeof(arg));

};



static inline int hif_set_arp_ipv4_filter(struct wfx_vif *wvif,

					  struct hif_mib_arp_ip_addr_table *fp)

{

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_ARP_IP_ADDRESSES_TABLE,

			     fp, sizeof(*fp));

}



static inline int hif_use_multi_tx_conf(struct wfx_dev *wdev,

					bool enabled)

{

	__le32 arg = enabled ? cpu_to_le32(1) : 0;



	return hif_write_mib(wdev, -1, HIF_MIB_ID_GL_SET_MULTI_MSG,

			     &arg, sizeof(arg));

}



static inline int hif_set_uapsd_info(struct wfx_vif *wvif,

				     struct hif_mib_set_uapsd_information *arg)

{

	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_SET_UAPSD_INFORMATION,

			     arg, sizeof(*arg));

}



static inline int hif_erp_use_protection(struct wfx_vif *wvif, bool enable)

{

	__le32 arg = enable ? cpu_to_le32(1) : 0;



	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_NON_ERP_PROTECTION, &arg, sizeof(arg));

}



static inline int hif_slot_time(struct wfx_vif *wvif, int val)

{

	__le32 arg = cpu_to_le32(val);



	return hif_write_mib(wvif->wdev, wvif->id, HIF_MIB_ID_SLOT_TIME,

			     &arg, sizeof(arg));

}



static inline int hif_dual_cts_protection(struct wfx_vif *wvif, bool val)

{

	struct hif_mib_set_ht_protection arg = {

		.dual_cts_prot = val,

	};



	return hif_write_mib(wvif->wdev, wvif->id, HIF_MIB_ID_SET_HT_PROTECTION,

			     &arg, sizeof(arg));

}



static inline int hif_wep_default_key_id(struct wfx_vif *wvif, int val)

{

	__le32 arg = cpu_to_le32(val);



	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_DOT11_WEP_DEFAULT_KEY_ID,

			     &arg, sizeof(arg));

}



static inline int hif_rts_threshold(struct wfx_vif *wvif, int val)

{

	__le32 arg = cpu_to_le32(val > 0 ? val : 0xFFFF);



	return hif_write_mib(wvif->wdev, wvif->id,

			     HIF_MIB_ID_DOT11_RTS_THRESHOLD, &arg, sizeof(arg));

}



#endif