Commit f9ec8006 authored by Al Viro's avatar Al Viro
Browse files

infiniband: umode_t noise, including open-coded S_ISDIR() 



Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent faef2b6c

drivers/infiniband/hw/ipath/ipath_fs.c

+3 −3
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ 
static struct super_block *ipath_super;



static int ipathfs_mknod(struct inode *dir, struct dentry *dentry,

			 int mode, const struct file_operations *fops,

			 umode_t mode, const struct file_operations *fops,

			 void *data)

{

	int error;
@@ -61,7 +61,7 @@ static int ipathfs_mknod(struct inode *dir, struct dentry *dentry, 
	inode->i_mode = mode;

	inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;

	inode->i_private = data;

	if ((mode & S_IFMT) == S_IFDIR) {

	if (S_ISDIR(mode)) {

		inode->i_op = &simple_dir_inode_operations;

		inc_nlink(inode);

		inc_nlink(dir);
@@ -76,7 +76,7 @@ static int ipathfs_mknod(struct inode *dir, struct dentry *dentry, 
	return error;

}



static int create_file(const char *name, mode_t mode,

static int create_file(const char *name, umode_t mode,

		       struct dentry *parent, struct dentry **dentry,

		       const struct file_operations *fops, void *data)

{

drivers/infiniband/hw/qib/qib_fs.c

+3 −3
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ static struct super_block *qib_super; 
#define private2dd(file) ((file)->f_dentry->d_inode->i_private)



static int qibfs_mknod(struct inode *dir, struct dentry *dentry,

		       int mode, const struct file_operations *fops,

		       umode_t mode, const struct file_operations *fops,

		       void *data)

{

	int error;
@@ -67,7 +67,7 @@ static int qibfs_mknod(struct inode *dir, struct dentry *dentry, 
	inode->i_mtime = inode->i_atime;

	inode->i_ctime = inode->i_atime;

	inode->i_private = data;

	if ((mode & S_IFMT) == S_IFDIR) {

	if (S_ISDIR(mode)) {

		inode->i_op = &simple_dir_inode_operations;

		inc_nlink(inode);

		inc_nlink(dir);
@@ -82,7 +82,7 @@ static int qibfs_mknod(struct inode *dir, struct dentry *dentry, 
	return error;

}



static int create_file(const char *name, mode_t mode,

static int create_file(const char *name, umode_t mode,

		       struct dentry *parent, struct dentry **dentry,

		       const struct file_operations *fops, void *data)

{