Commit fa8ba350 authored by Jiri Pirko's avatar Jiri Pirko Committed by Jakub Kicinski
Browse files

ynl-gen-c.py: render netlink policies static for split ops 



When policies are rendered for split ops, they are consumed in the same
file. No need to expose them for user outside, make them static.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20230803111340.1074067-5-jiri@resnulli.us


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent eab7be68

tools/net/ynl/ynl-gen-c.py

+6 −2
Original line number Diff line number Diff line
@@ -1843,13 +1843,13 @@ def print_ntf_type_free(ri): 




def print_req_policy_fwd(cw, struct, ri=None, terminate=True):

    if terminate and ri and kernel_can_gen_family_struct(struct.family):

    if terminate and ri and policy_should_be_static(struct.family):

        return



    if terminate:

        prefix = 'extern '

    else:

        if kernel_can_gen_family_struct(struct.family) and ri:

        if ri and policy_should_be_static(struct.family):

            prefix = 'static '

        else:

            prefix = ''
@@ -1877,6 +1877,10 @@ def kernel_can_gen_family_struct(family): 
    return family.proto == 'genetlink'





def policy_should_be_static(family):

    return family.kernel_policy == 'split' or kernel_can_gen_family_struct(family)





def print_kernel_op_table_fwd(family, cw, terminate):

    exported = not kernel_can_gen_family_struct(family)