Commit fb394f3f authored by Dongliang Mu's avatar Dongliang Mu Committed by Mauro Carvalho Chehab
Browse files

media: driver: hva: add pm_runtime_disable in the error handling code of hva_hw_probe 



In the error handling code of hva_hw_probe, it fails to invoke
pm_runtime_disable in many error sites.

Fix this by adding a label err_disable with pm_runtime_disable and
adjust one goto from label err_clk to err_disable.

Signed-off-by: default avatarDongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 9175fb66

drivers/media/platform/sti/hva/hva-hw.c

+3 −1
Original line number Diff line number Diff line
@@ -385,7 +385,7 @@ int hva_hw_probe(struct platform_device *pdev, struct hva_dev *hva) 
	ret = pm_runtime_resume_and_get(dev);

	if (ret < 0) {

		dev_err(dev, "%s     failed to set PM\n", HVA_PREFIX);

		goto err_clk;

		goto err_disable;

	}



	/* check IP hardware version */
@@ -403,6 +403,8 @@ int hva_hw_probe(struct platform_device *pdev, struct hva_dev *hva) 


err_pm:

	pm_runtime_put(dev);

err_disable:

	pm_runtime_disable(dev);

err_clk:

	if (hva->clk)

		clk_unprepare(hva->clk);