Commit fc6138b6 authored by Chaehyun Lim's avatar Chaehyun Lim Committed by Greg Kroah-Hartman
Browse files

staging: wilc1000: change handle_set_ip_address's return type to void



When handle_set_ip_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due to have
a single statement.

Signed-off-by: default avatarChaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 14f3b086
Loading
Loading
Loading
Loading
+2 −6
Original line number Diff line number Diff line
@@ -349,7 +349,7 @@ static void handle_set_operation_mode(struct wilc_vif *vif,
		netdev_err(vif->ndev, "Failed to set driver handler\n");
}

static s32 handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)
static void handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)
{
	s32 result = 0;
	struct wid wid;
@@ -370,12 +370,8 @@ static s32 handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)

	host_int_get_ipaddress(vif, firmware_ip_addr, idx);

	if (result) {
	if (result)
		netdev_err(vif->ndev, "Failed to set IP address\n");
		return -EINVAL;
	}

	return result;
}

static s32 handle_get_ip_address(struct wilc_vif *vif, u8 idx)