Commit fd3cdd93 authored by Chris Wilson's avatar Chris Wilson Committed by Rodrigo Vivi
Browse files

drm/i915: Remove truncation warning for large objects 

Having addressed the issues surrounding incorrect types for local
variables and potential integer truncation in using the scatterlist API,
we have closed all the loop holes we had previously identified with
dangerously large object creation. As such, we can eliminate the warning
put in place to remind us to complete the review.

Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Brian Welty <brian.welty@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Testcase: igt@gem_create@create-massive
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4991


Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Reviewed-by: default avatarNirmoy Das <nirmoy.das@intel.com>
Reviewed-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221228192252.917299-7-gwan-gyeong.mun@intel.com
parent 18f968cb

drivers/gpu/drm/i915/gem/i915_gem_object.h

+0 −15
Original line number Diff line number Diff line
@@ -20,25 +20,10 @@ 


enum intel_region_id;



/*

 * XXX: There is a prevalence of the assumption that we fit the

 * object's page count inside a 32bit _signed_ variable. Let's document

 * this and catch if we ever need to fix it. In the meantime, if you do

 * spot such a local variable, please consider fixing!

 *

 * We can check for invalidly typed locals with typecheck(), see for example

 * i915_gem_object_get_sg().

 */

#define GEM_CHECK_SIZE_OVERFLOW(sz) \

	GEM_WARN_ON((sz) >> PAGE_SHIFT > INT_MAX)



static inline bool i915_gem_object_size_2big(u64 size)

{

	struct drm_i915_gem_object *obj;



	if (GEM_CHECK_SIZE_OVERFLOW(size))

		return true;



	if (overflows_type(size, obj->base.size))

		return true;