Commit fdfc119c authored by SeongJae Park's avatar SeongJae Park Committed by Andrew Morton
Browse files

mm/damon/reclaim: use monitoring attributes parameters generator macro 

This commit makes DAMON_RECLAIM to generate the module parameters for
DAMON monitoring attributes using the generator macro to simplify the code
and reduce duplicates.

Link: https://lkml.kernel.org/r/20220913174449.50645-12-sj@kernel.org


Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 95f7c05d

mm/damon/reclaim.c

+5 −42
Original line number Diff line number Diff line
@@ -13,6 +13,8 @@ 
#include <linux/sched.h>

#include <linux/workqueue.h>



#include "modules-common.h"



#ifdef MODULE_PARAM_PREFIX

#undef MODULE_PARAM_PREFIX

#endif
@@ -130,52 +132,13 @@ static unsigned long wmarks_low __read_mostly = 200; 
module_param(wmarks_low, ulong, 0600);



static struct damon_attrs damon_reclaim_mon_attrs = {

	.sample_interval = 5000,

	.aggr_interval = 100000,

	.sample_interval = 5000,	/* 5 ms */

	.aggr_interval = 100000,	/* 100 ms */

	.ops_update_interval = 0,

	.min_nr_regions = 10,

	.max_nr_regions = 1000,

};



/*

 * Sampling interval for the monitoring in microseconds.

 *

 * The sampling interval of DAMON for the cold memory monitoring.  Please refer

 * to the DAMON documentation for more detail.  5 ms by default.

 */

module_param_named(sample_interval, damon_reclaim_mon_attrs.sample_interval,

		ulong, 0600);



/*

 * Aggregation interval for the monitoring in microseconds.

 *

 * The aggregation interval of DAMON for the cold memory monitoring.  Please

 * refer to the DAMON documentation for more detail.  100 ms by default.

 */

module_param_named(aggr_interval, damon_reclaim_mon_attrs.aggr_interval, ulong,

		0600);



/*

 * Minimum number of monitoring regions.

 *

 * The minimal number of monitoring regions of DAMON for the cold memory

 * monitoring.  This can be used to set lower-bound of the monitoring quality.

 * But, setting this too high could result in increased monitoring overhead.

 * Please refer to the DAMON documentation for more detail.  10 by default.

 */

module_param_named(min_nr_regions, damon_reclaim_mon_attrs.min_nr_regions,

		ulong, 0600);



/*

 * Maximum number of monitoring regions.

 *

 * The maximum number of monitoring regions of DAMON for the cold memory

 * monitoring.  This can be used to set upper-bound of the monitoring overhead.

 * However, setting this too low could result in bad monitoring quality.

 * Please refer to the DAMON documentation for more detail.  1000 by default.

 */

module_param_named(max_nr_regions, damon_reclaim_mon_attrs.max_nr_regions,

		ulong, 0600);

DEFINE_DAMON_MODULES_MON_ATTRS_PARAMS(damon_reclaim_mon_attrs);



/*

 * Start of the target memory region in physical address.