Commit ff2b46d7 authored by Dinghao Liu's avatar Dinghao Liu Committed by Will Deacon
Browse files

iommu/intel: Fix memleak in intel_irq_remapping_alloc 



When irq_domain_get_irq_data() or irqd_cfg() fails
at i == 0, data allocated by kzalloc() has not been
freed before returning, which leads to memleak.

Fixes: b106ee63 ("irq_remapping/vt-d: Enhance Intel IR driver to support hierarchical irqdomains")
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/20210105051837.32118-1-dinghao.liu@zju.edu.cn


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 6775ae90

drivers/iommu/intel/irq_remapping.c

+2 −0
Original line number Diff line number Diff line
@@ -1353,6 +1353,8 @@ static int intel_irq_remapping_alloc(struct irq_domain *domain, 
		irq_data = irq_domain_get_irq_data(domain, virq + i);

		irq_cfg = irqd_cfg(irq_data);

		if (!irq_data || !irq_cfg) {

			if (!i)

				kfree(data);

			ret = -EINVAL;

			goto out_free_data;

		}