Commit ff47dbd1 authored Jun 02, 2022 by Damien Le Moal Committed by Jens Axboe Jun 02, 2022

block: remove useless BUG_ON() in blk_mq_put_tag()

Since the if condition in blk_mq_put_tag() checks that the tag to put is
not a reserved one, the BUG_ON() check in the else branch checking if
the tag is indeed a reserved one is useless. Remove it.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Link: https://lore.kernel.org/r/20220602075159.1273366-1-damien.lemoal@opensource.wdc.com

Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent b81c14ca

block/blk-mq-tag.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -228,7 +228,6 @@ void blk_mq_put_tag(struct blk_mq_tags tags, struct blk_mq_ctx ctx,
	BUG_ON(real_tag >= tags->nr_tags);		BUG_ON(real_tag >= tags->nr_tags);
	sbitmap_queue_clear(&tags->bitmap_tags, real_tag, ctx->cpu);		sbitmap_queue_clear(&tags->bitmap_tags, real_tag, ctx->cpu);
	} else {		} else {
	BUG_ON(tag >= tags->nr_reserved_tags);
	sbitmap_queue_clear(&tags->breserved_tags, tag, ctx->cpu);		sbitmap_queue_clear(&tags->breserved_tags, tag, ctx->cpu);
	}		}
	}		}