Skip to content
  • Hangbin Liu's avatar
    58e0be1e
    net: use struct_group to copy ip/ipv6 header addresses · 58e0be1e
    Hangbin Liu authored
    
    
    kernel test robot reported warnings when build bonding module with
    make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/bonding/:
    
                     from ../drivers/net/bonding/bond_main.c:35:
    In function ‘fortify_memcpy_chk’,
        inlined from ‘iph_to_flow_copy_v4addrs’ at ../include/net/ip.h:566:2,
        inlined from ‘bond_flow_ip’ at ../drivers/net/bonding/bond_main.c:3984:3:
    ../include/linux/fortify-string.h:413:25: warning: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of f
    ield (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
      413 |                         __read_overflow2_field(q_size_field, size);
          |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    In function ‘fortify_memcpy_chk’,
        inlined from ‘iph_to_flow_copy_v6addrs’ at ../include/net/ipv6.h:900:2,
        inlined from ‘bond_flow_ip’ at ../drivers/net/bonding/bond_main.c:3994:3:
    ../include/linux/fortify-string.h:413:25: warning: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of f
    ield (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
      413 |                         __read_overflow2_field(q_size_field, size);
          |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    This is because we try to copy the whole ip/ip6 address to the flow_key,
    while we only point the to ip/ip6 saddr. Note that since these are UAPI
    headers, __struct_group() is used to avoid the compiler warnings.
    
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Fixes: c3f83241 ("net: Add full IPv6 addresses to flow_keys")
    Signed-off-by: default avatarHangbin Liu <liuhangbin@gmail.com>
    Link: https://lore.kernel.org/r/20221115142400.1204786-1-liuhangbin@gmail.com
    
    
    Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    58e0be1e
    net: use struct_group to copy ip/ipv6 header addresses
    Hangbin Liu authored
    
    
    kernel test robot reported warnings when build bonding module with
    make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/bonding/:
    
                     from ../drivers/net/bonding/bond_main.c:35:
    In function ‘fortify_memcpy_chk’,
        inlined from ‘iph_to_flow_copy_v4addrs’ at ../include/net/ip.h:566:2,
        inlined from ‘bond_flow_ip’ at ../drivers/net/bonding/bond_main.c:3984:3:
    ../include/linux/fortify-string.h:413:25: warning: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of f
    ield (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
      413 |                         __read_overflow2_field(q_size_field, size);
          |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    In function ‘fortify_memcpy_chk’,
        inlined from ‘iph_to_flow_copy_v6addrs’ at ../include/net/ipv6.h:900:2,
        inlined from ‘bond_flow_ip’ at ../drivers/net/bonding/bond_main.c:3994:3:
    ../include/linux/fortify-string.h:413:25: warning: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of f
    ield (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
      413 |                         __read_overflow2_field(q_size_field, size);
          |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    This is because we try to copy the whole ip/ip6 address to the flow_key,
    while we only point the to ip/ip6 saddr. Note that since these are UAPI
    headers, __struct_group() is used to avoid the compiler warnings.
    
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Fixes: c3f83241 ("net: Add full IPv6 addresses to flow_keys")
    Signed-off-by: default avatarHangbin Liu <liuhangbin@gmail.com>
    Link: https://lore.kernel.org/r/20221115142400.1204786-1-liuhangbin@gmail.com
    
    
    Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Loading