staging: ks7010: fix complete_handler
complete_handler() takes void * types as parameters. void * parameters are then cast to struct types. Call sites for this function either pass in NULL or pointers to the struct types cast to void *. This casting is unnecessary and can be removed. Struct tx_device_buffer (which contains a pointer member to the complete_handler() function) has as member 'ks_wlan_priv *priv' this is unnecessary, we always have a pointer to this struct there is no need to store it here. The complete_handler can be more clearly defined by using struct pointer types instead of void * types. The code is currently unnecessarily complex, storing and passing extraneous pointer parameters. Remove unnecessary parameters, unnecessary casting to/from 'void *'. Fix all call sites involving complete_handler(). Signed-off-by:Tobin C. Harding <me@tobin.cc> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Showing
- drivers/staging/ks7010/ks7010_sdio.c 11 additions, 10 deletionsdrivers/staging/ks7010/ks7010_sdio.c
- drivers/staging/ks7010/ks7010_sdio.h 3 additions, 3 deletionsdrivers/staging/ks7010/ks7010_sdio.h
- drivers/staging/ks7010/ks_hostif.c 16 additions, 19 deletionsdrivers/staging/ks7010/ks_hostif.c
- drivers/staging/ks7010/ks_hostif.h 4 additions, 3 deletionsdrivers/staging/ks7010/ks_hostif.h
- drivers/staging/ks7010/ks_wlan_net.c 4 additions, 8 deletionsdrivers/staging/ks7010/ks_wlan_net.c
Loading
Please register or sign in to comment