Commit 06cd7423 authored Apr 08, 2021 by Shixin Liu Committed by Herbert Xu Apr 16, 2021

crypto: sun8i-ss - Fix PM reference leak when pm_runtime_get_sync() fails



pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent ac98fc5e

drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -354,7 +354,7 @@ int sun8i_ss_cipher_init(struct crypto_tfm *tfm)
		op->enginectx.op.prepare_request = NULL;
		op->enginectx.op.unprepare_request = NULL;

		err = pm_runtime_get_sync(op->ss->dev);
		err = pm_runtime_resume_and_get(op->ss->dev);
		if (err < 0) {
		dev_err(op->ss->dev, "pm error %d\n", err);
		goto error_pm;

drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -753,7 +753,7 @@ static int sun8i_ss_probe(struct platform_device *pdev)
		if (err)
		goto error_alg;

		err = pm_runtime_get_sync(ss->dev);
		err = pm_runtime_resume_and_get(ss->dev);
		if (err < 0)
		goto error_alg;