mmc: change .get_ro() callback semantics
Now get_ro() callback must return 0/1 values for its logical states, and negative errno values in case of error. If particular host instance doesn't support RO/WP switch, it should return -ENOSYS. This patch changes some hosts in two ways: 1. Now functions should be smart to not return negative values in "RO asserted" case (particularly gpio_ calls could return negative values for the outermost GPIOs). Also, board code usually passes get_ro() callbacks that directly return gpioreg & bit result, so at91_mci, imxmmc, pxamci and mmc_spi's get_ro() handlers need take special care when returning platform's values to the mmc core. 2. In case of host instance didn't implement get_ro() callback, it should really return -ENOSYS and let the mmc core decide what to do about it (mmc core thinks the same way as the hosts, so it isn't functional change). Signed-off-by:Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by:
Pierre Ossman <drzeus@drzeus.cx>
Showing
- drivers/mmc/core/sd.c 2 additions, 2 deletionsdrivers/mmc/core/sd.c
- drivers/mmc/host/at91_mci.c 7 additions, 11 deletionsdrivers/mmc/host/at91_mci.c
- drivers/mmc/host/imxmmc.c 6 additions, 3 deletionsdrivers/mmc/host/imxmmc.c
- drivers/mmc/host/mmc_spi.c 6 additions, 3 deletionsdrivers/mmc/host/mmc_spi.c
- drivers/mmc/host/pxamci.c 6 additions, 3 deletionsdrivers/mmc/host/pxamci.c
- drivers/mmc/host/wbsd.c 1 addition, 1 deletiondrivers/mmc/host/wbsd.c
- include/linux/mmc/host.h 12 additions, 0 deletionsinclude/linux/mmc/host.h
Loading
Please register or sign in to comment