Commit 2d29f81c authored by Xiangyang Zhang's avatar Xiangyang Zhang Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: Fix a resource leak in update_bcn_wps_ie 



The "pbackup_remainder_ie" variable is not freed when "pwps_ie_src" is null

Fixes: 15865124 ("staging: r8188eu: introduce new core dir for RTL8188eu driver")
Acked-by: default avatarMichael Straube <straube.linux@gmail.com>
Signed-off-by: default avatarXiangyang Zhang <xyz.sun.ok@gmail.com>
Link: https://lore.kernel.org/r/20210821081824.14745-1-xyz.sun.ok@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5598e47a

drivers/staging/r8188eu/core/rtw_ap.c

+2 −1
Original line number Diff line number Diff line
@@ -1199,7 +1199,7 @@ static void update_bcn_wps_ie(struct adapter *padapter) 


	pwps_ie_src = pmlmepriv->wps_beacon_ie;

	if (!pwps_ie_src)

		return;

		goto exit;



	wps_ielen = (uint)pwps_ie_src[1];/* to get ie data len */

	if ((wps_offset + wps_ielen + 2 + remainder_ielen) <= MAX_IE_SZ) {
@@ -1213,6 +1213,7 @@ static void update_bcn_wps_ie(struct adapter *padapter) 
		pnetwork->IELength = wps_offset + (wps_ielen + 2) + remainder_ielen;

	}



exit:

	kfree(pbackup_remainder_ie);

}