kbuild: build init/built-in.a just once
Kbuild builds init/built-in.a twice; first during the ordinary
directory descending, second from scripts/link-vmlinux.sh.
We do this because UTS_VERSION contains the build version and the
timestamp. We cannot update it during the normal directory traversal
since we do not yet know if we need to update vmlinux. UTS_VERSION is
temporarily calculated, but omitted from the update check. Otherwise,
vmlinux would be rebuilt every time.
When Kbuild results in running link-vmlinux.sh, it increments the
version number in the .version file and takes the timestamp at that
time to really fix UTS_VERSION.
However, updating the same file twice is a footgun. To avoid nasty
timestamp issues, all build artifacts that depend on init/built-in.a
are atomically generated in link-vmlinux.sh, where some of them do not
need rebuilding.
To fix this issue, this commit changes as follows:
[1] Split UTS_VERSION out to include/generated/utsversion.h from
include/generated/compile.h
include/generated/utsversion.h is generated just before the
vmlinux link. It is generated under include/generated/ because
some decompressors (s390, x86) use UTS_VERSION.
[2] Split init_uts_ns and linux_banner out to init/version-timestamp.c
from init/version.c
init_uts_ns and linux_banner contain UTS_VERSION. During the ordinary
directory descending, they are compiled with __weak and used to
determine if vmlinux needs relinking. Just before the vmlinux link,
they are compiled without __weak to embed the real version and
timestamp.
Signed-off-by:
Masahiro Yamada <masahiroy@kernel.org>
Showing
- arch/powerpc/boot/wrapper 1 addition, 1 deletionarch/powerpc/boot/wrapper
- arch/s390/boot/version.c 1 addition, 0 deletionsarch/s390/boot/version.c
- arch/x86/boot/compressed/kaslr.c 1 addition, 0 deletionsarch/x86/boot/compressed/kaslr.c
- arch/x86/boot/version.c 1 addition, 0 deletionsarch/x86/boot/version.c
- init/.gitignore 2 additions, 0 deletionsinit/.gitignore
- init/Makefile 42 additions, 13 deletionsinit/Makefile
- init/build-version 10 additions, 0 deletionsinit/build-version
- init/version-timestamp.c 31 additions, 0 deletionsinit/version-timestamp.c
- init/version.c 13 additions, 23 deletionsinit/version.c
- kernel/gen_kheaders.sh 3 additions, 3 deletionskernel/gen_kheaders.sh
- scripts/link-vmlinux.sh 4 additions, 13 deletionsscripts/link-vmlinux.sh
- scripts/mkcompile_h 11 additions, 78 deletionsscripts/mkcompile_h
Loading
Please register or sign in to comment