Commit 2f413956 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: don't set TASK_RUNNING in local tw runner 



The CQ waiting loop sets TASK_RUNNING before trying to execute
task_work, no need to repeat it in io_run_local_work().

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/9d9422c429ef3f9457b4f4b8288bf4789564f33b.1673274244.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent bd550173

io_uring/io_uring.c

+2 −3
Original line number Diff line number Diff line
@@ -1339,11 +1339,9 @@ int __io_run_local_work(struct io_ring_ctx *ctx, bool *locked) 


int io_run_local_work(struct io_ring_ctx *ctx)

{

	bool locked;

	bool locked = mutex_trylock(&ctx->uring_lock);

	int ret;



	__set_current_state(TASK_RUNNING);

	locked = mutex_trylock(&ctx->uring_lock);

	ret = __io_run_local_work(ctx, &locked);

	if (locked)

		mutex_unlock(&ctx->uring_lock);
@@ -2453,6 +2451,7 @@ static int io_wake_function(struct wait_queue_entry *curr, unsigned int mode, 
int io_run_task_work_sig(struct io_ring_ctx *ctx)

{

	if (!llist_empty(&ctx->work_llist)) {

		__set_current_state(TASK_RUNNING);

		if (io_run_local_work(ctx) > 0)

			return 1;

	}