unix: correctly track in-flight fds in sending process user_struct
The commit referenced in the Fixes tag incorrectly accounted the number of in-flight fds over a unix domain socket to the original opener of the file-descriptor. This allows another process to arbitrary deplete the original file-openers resource limit for the maximum of open files. Instead the sending processes and its struct cred should be credited. To do so, we add a reference counted struct user_struct pointer to the scm_fp_list and use it to account for the number of inflight unix fds. Fixes: 712f4aad ("unix: properly account for FDs passed over unix sockets") Reported-by:David Herrmann <dh.herrmann@gmail.com> Cc: David Herrmann <dh.herrmann@gmail.com> Cc: Willy Tarreau <w@1wt.eu> Cc: Linus Torvalds <torvalds@linux-foundation.org> Suggested-by:
Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by:
Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- include/net/af_unix.h 2 additions, 2 deletionsinclude/net/af_unix.h
- include/net/scm.h 1 addition, 0 deletionsinclude/net/scm.h
- net/core/scm.c 7 additions, 0 deletionsnet/core/scm.c
- net/unix/af_unix.c 2 additions, 2 deletionsnet/unix/af_unix.c
- net/unix/garbage.c 4 additions, 4 deletionsnet/unix/garbage.c
Loading
Please register or sign in to comment