networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy() some data into the new space, introduce skb_put_data() for this. An spatch similar to the one for skb_put_zero() converts many of the places using it: @@ identifier p, p2; expression len, skb, data; type t, t2; @@ ( -p = skb_put(skb, len); +p = skb_put_data(skb, data, len); | -p = (t)skb_put(skb, len); +p = skb_put_data(skb, data, len); ) ( p2 = (t2)p; -memcpy(p2, data, len); | -memcpy(p, data, len); ) @@ type t, t2; identifier p, p2; expression skb, data; @@ t *p; ... ( -p = skb_put(skb, sizeof(t)); +p = skb_put_data(skb, data, sizeof(t)); | -p = (t *)skb_put(skb, sizeof(t)); +p = skb_put_data(skb, data, sizeof(t)); ) ( p2 = (t2)p; -memcpy(p2, data, sizeof(*p)); | -memcpy(p, data, sizeof(*p)); ) @@ expression skb, len, data; @@ -memcpy(skb_put(skb, len), data, len); +skb_put_data(skb, data, len); (again, manually post-processed to retain some comments) Reviewed-by:Stephen Hemminger <stephen@networkplumber.org> Signed-off-by:
Johannes Berg <johannes.berg@intel.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- drivers/atm/fore200e.c 1 addition, 1 deletiondrivers/atm/fore200e.c
- drivers/atm/he.c 1 addition, 1 deletiondrivers/atm/he.c
- drivers/atm/idt77252.c 4 additions, 7 deletionsdrivers/atm/idt77252.c
- drivers/atm/solos-pci.c 1 addition, 1 deletiondrivers/atm/solos-pci.c
- drivers/bluetooth/bfusb.c 3 additions, 3 deletionsdrivers/bluetooth/bfusb.c
- drivers/bluetooth/bluecard_cs.c 1 addition, 1 deletiondrivers/bluetooth/bluecard_cs.c
- drivers/bluetooth/btmrvl_main.c 1 addition, 1 deletiondrivers/bluetooth/btmrvl_main.c
- drivers/bluetooth/btqcomsmd.c 1 addition, 1 deletiondrivers/bluetooth/btqcomsmd.c
- drivers/bluetooth/btusb.c 6 additions, 6 deletionsdrivers/bluetooth/btusb.c
- drivers/bluetooth/hci_bcsp.c 8 additions, 8 deletionsdrivers/bluetooth/hci_bcsp.c
- drivers/bluetooth/hci_h4.c 1 addition, 1 deletiondrivers/bluetooth/hci_h4.c
- drivers/bluetooth/hci_h5.c 6 additions, 6 deletionsdrivers/bluetooth/hci_h5.c
- drivers/bluetooth/hci_intel.c 3 additions, 4 deletionsdrivers/bluetooth/hci_intel.c
- drivers/bluetooth/hci_ll.c 1 addition, 1 deletiondrivers/bluetooth/hci_ll.c
- drivers/bluetooth/hci_mrvl.c 1 addition, 1 deletiondrivers/bluetooth/hci_mrvl.c
- drivers/bluetooth/hci_qca.c 1 addition, 1 deletiondrivers/bluetooth/hci_qca.c
- drivers/char/pcmcia/synclink_cs.c 1 addition, 1 deletiondrivers/char/pcmcia/synclink_cs.c
- drivers/firewire/net.c 1 addition, 1 deletiondrivers/firewire/net.c
- drivers/isdn/capi/capi.c 1 addition, 1 deletiondrivers/isdn/capi/capi.c
- drivers/isdn/capi/capidrv.c 1 addition, 1 deletiondrivers/isdn/capi/capidrv.c
Loading
Please register or sign in to comment