Skip to content
Commit 6662ae6a authored by Maxime Ripard's avatar Maxime Ripard Committed by Linus Walleij
Browse files

gpiolib: Keep returning EPROBE_DEFER when we should



Commits c8582339 ("gpio: of: Support SPI nonstandard GPIO properties")
and 6a537d48 ("gpio: of: Support regulator nonstandard GPIO
properties") have introduced a regression in the way error codes from
of_get_named_gpiod_flags are handled.

Previously, those errors codes were returned immediately, but the two
commits mentioned above are now overwriting the error pointer, meaning that
whatever value has been returned will be dropped in favor of whatever the
two new functions will return.

This might not be a big deal except for EPROBE_DEFER, on which GPIOlib
customers will depend on, and that will now be returned as an hard error
which means that they will not probe anymore, instead of gently deferring
their probe.

Since EPROBE_DEFER basically means that we have found a valid property but
there was no GPIO controller registered to handle it, fix this issues by
returning it as soon as we encounter it.

Fixes: c8582339 ("gpio: of: Support SPI nonstandard GPIO properties")
Fixes: 6a537d48 ("gpio: of: Support regulator nonstandard GPIO properties")
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
[Fold in fix to the fix]
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 7928b2cb
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment