Commit 6a5c2319 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

staging: csr: use is_zero_ether_addr() instead of memcmp() 

Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/

)

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c8be681f

drivers/staging/csr/sme_wext.c

+1 −3
Original line number Diff line number Diff line
@@ -1191,8 +1191,6 @@ unifi_siwap(struct net_device *dev, struct iw_request_info *info, 
    netInterface_priv_t *interfacePriv = (netInterface_priv_t *)netdev_priv(dev);

    unifi_priv_t *priv = interfacePriv->privPtr;

    int err = 0;

    const unsigned char zero_bssid[ETH_ALEN] = {0x00, 0x00, 0x00,

        0x00, 0x00, 0x00};



    func_enter();
@@ -1213,7 +1211,7 @@ unifi_siwap(struct net_device *dev, struct iw_request_info *info, 
	unifi_trace(priv, UDBG1, "unifi_siwap: asked for %pM\n",

		wrqu->ap_addr.sa_data);



    if (!memcmp(wrqu->ap_addr.sa_data, zero_bssid, ETH_ALEN)) {

    if (is_zero_ether_addr(wrqu->ap_addr.sa_data)) {

        priv->ignore_bssid_join = FALSE;

        err = sme_mgt_disconnect(priv);

        if (err) {