Commit 8fee79ed authored by Li Heng's avatar Li Heng Committed by Martin K. Petersen
Browse files

scsi: mptctl: Remove unneeded cast from memory allocation 

Remove casting the values returned by memory allocation function.

Coccinelle emits WARNING:

./drivers/message/fusion/mptctl.c:2596:14-31: WARNING: casting value returned by memory allocation function to (SCSIDevicePage0_t *) is useless.
./drivers/message/fusion/mptctl.c:2660:15-32: WARNING: casting value returned by memory allocation function to (SCSIDevicePage3_t *) is useless.

Link: https://lore.kernel.org/r/1596014390-18605-1-git-send-email-liheng40@huawei.com


Signed-off-by: default avatarLi Heng <liheng40@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 33fff97c

drivers/message/fusion/mptctl.c

+2 −3
Original line number Diff line number Diff line
@@ -2593,7 +2593,7 @@ mptctl_hp_targetinfo(MPT_ADAPTER *ioc, unsigned long arg) 
       /* Get the data transfer speeds

        */

	data_sz = ioc->spi_data.sdp0length * 4;

	pg0_alloc = (SCSIDevicePage0_t *) pci_alloc_consistent(ioc->pcidev, data_sz, &page_dma);

	pg0_alloc = pci_alloc_consistent(ioc->pcidev, data_sz, &page_dma);

	if (pg0_alloc) {

		hdr.PageVersion = ioc->spi_data.sdp0version;

		hdr.PageLength = data_sz;
@@ -2657,8 +2657,7 @@ mptctl_hp_targetinfo(MPT_ADAPTER *ioc, unsigned long arg) 
		/* Issue the second config page request */

		cfg.action = MPI_CONFIG_ACTION_PAGE_READ_CURRENT;

		data_sz = (int) cfg.cfghdr.hdr->PageLength * 4;

		pg3_alloc = (SCSIDevicePage3_t *) pci_alloc_consistent(

							ioc->pcidev, data_sz, &page_dma);

		pg3_alloc = pci_alloc_consistent(ioc->pcidev, data_sz, &page_dma);

		if (pg3_alloc) {

			cfg.physAddr = page_dma;

			cfg.pageAddr = (karg.hdr.channel << 8) | karg.hdr.id;