powerpc: Convert power off logic to pm_power_off
The generic Linux framework to power off the machine is a function pointer called pm_power_off. The trick about this pointer is that device drivers can potentially implement it rather than board files. Today on powerpc we set pm_power_off to invoke our generic full machine power off logic which then calls ppc_md.power_off to invoke machine specific power off. However, when we want to add a power off GPIO via the "gpio-poweroff" driver, this card house falls apart. That driver only registers itself if pm_power_off is NULL to ensure it doesn't override board specific logic. However, since we always set pm_power_off to the generic power off logic (which will just not power off the machine if no ppc_md.power_off call is implemented), we can't implement power off via the generic GPIO power off driver. To fix this up, let's get rid of the ppc_md.power_off logic and just always use pm_power_off as was intended. Then individual drivers such as the GPIO power off driver can implement power off logic via that function pointer. With this patch set applied and a few patches on top of QEMU that implement a power off GPIO on the virt e500 machine, I can successfully turn off my virtual machine after halt. Signed-off-by:Alexander Graf <agraf@suse.de> [mpe: Squash into one patch and update changelog based on cover letter] Signed-off-by:
Michael Ellerman <mpe@ellerman.id.au>
Showing
- arch/powerpc/include/asm/machdep.h 0 additions, 1 deletionarch/powerpc/include/asm/machdep.h
- arch/powerpc/kernel/setup-common.c 3 additions, 3 deletionsarch/powerpc/kernel/setup-common.c
- arch/powerpc/platforms/44x/ppc476.c 1 addition, 1 deletionarch/powerpc/platforms/44x/ppc476.c
- arch/powerpc/platforms/52xx/efika.c 2 additions, 1 deletionarch/powerpc/platforms/52xx/efika.c
- arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c 4 additions, 4 deletionsarch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
- arch/powerpc/platforms/85xx/corenet_generic.c 1 addition, 1 deletionarch/powerpc/platforms/85xx/corenet_generic.c
- arch/powerpc/platforms/85xx/sgy_cts1000.c 2 additions, 2 deletionsarch/powerpc/platforms/85xx/sgy_cts1000.c
- arch/powerpc/platforms/cell/celleb_setup.c 2 additions, 2 deletionsarch/powerpc/platforms/cell/celleb_setup.c
- arch/powerpc/platforms/cell/qpace_setup.c 1 addition, 1 deletionarch/powerpc/platforms/cell/qpace_setup.c
- arch/powerpc/platforms/cell/setup.c 1 addition, 1 deletionarch/powerpc/platforms/cell/setup.c
- arch/powerpc/platforms/chrp/setup.c 2 additions, 1 deletionarch/powerpc/platforms/chrp/setup.c
- arch/powerpc/platforms/embedded6xx/gamecube.c 2 additions, 1 deletionarch/powerpc/platforms/embedded6xx/gamecube.c
- arch/powerpc/platforms/embedded6xx/linkstation.c 3 additions, 1 deletionarch/powerpc/platforms/embedded6xx/linkstation.c
- arch/powerpc/platforms/embedded6xx/wii.c 2 additions, 1 deletionarch/powerpc/platforms/embedded6xx/wii.c
- arch/powerpc/platforms/maple/setup.c 2 additions, 2 deletionsarch/powerpc/platforms/maple/setup.c
- arch/powerpc/platforms/powermac/setup.c 2 additions, 1 deletionarch/powerpc/platforms/powermac/setup.c
- arch/powerpc/platforms/powernv/setup.c 2 additions, 2 deletionsarch/powerpc/platforms/powernv/setup.c
- arch/powerpc/platforms/ps3/setup.c 1 addition, 1 deletionarch/powerpc/platforms/ps3/setup.c
- arch/powerpc/platforms/pseries/setup.c 30 additions, 29 deletionsarch/powerpc/platforms/pseries/setup.c
- arch/powerpc/sysdev/fsl_soc.c 1 addition, 1 deletionarch/powerpc/sysdev/fsl_soc.c
Loading
Please register or sign in to comment