Commit b22b8618 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: make OnAction_back static void 



OnAction_back is called only by OnAction, its return value is not checked.
We can make it a static void function.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20221030173326.1588647-5-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 721d7f49

drivers/staging/r8188eu/core/rtw_mlme_ext.c

+5 −8
Original line number Diff line number Diff line
@@ -1481,7 +1481,7 @@ static void OnDisassoc(struct adapter *padapter, struct recv_frame *precv_frame) 
	pmlmepriv->LinkDetectInfo.bBusyTraffic = false;

}



unsigned int OnAction_back(struct adapter *padapter, struct recv_frame *precv_frame)

static void OnAction_back(struct adapter *padapter, struct recv_frame *precv_frame)

{

	struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)precv_frame->rx_data;

	struct sta_info *psta = NULL;
@@ -1494,21 +1494,20 @@ unsigned int OnAction_back(struct adapter *padapter, struct recv_frame *precv_fr 
	struct sta_priv *pstapriv = &padapter->stapriv;

	/* check RA matches or not */

	if (memcmp(myid(&padapter->eeprompriv), mgmt->da, ETH_ALEN))/* for if1, sta/ap mode */

		return _SUCCESS;

		return;



	if ((pmlmeinfo->state & 0x03) != WIFI_FW_AP_STATE)

		if (!(pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS))

			return _SUCCESS;

			return;



	psta = rtw_get_stainfo(pstapriv, mgmt->sa);



	if (!psta)

		return _SUCCESS;

		return;



	frame_body = (unsigned char *)(pframe + sizeof(struct ieee80211_hdr_3addr));



	if (!pmlmeinfo->HT_enable)

		return _SUCCESS;

		return;

	/* All union members start with an action code, it's ok to use addba_req. */

	switch (mgmt->u.action.u.addba_req.action_code) {

	case WLAN_ACTION_ADDBA_REQ:
@@ -1550,8 +1549,6 @@ unsigned int OnAction_back(struct adapter *padapter, struct recv_frame *precv_fr 
	default:

		break;

	}



	return _SUCCESS;

}



static int get_reg_classes_full_count(struct p2p_channels *channel_list)

drivers/staging/r8188eu/include/rtw_mlme_ext.h

+0 −2
Original line number Diff line number Diff line
@@ -536,8 +536,6 @@ void start_clnt_auth(struct adapter *padapter); 
void start_clnt_join(struct adapter *padapter);

void start_create_ibss(struct adapter *padapter);



unsigned int OnAction_back(struct adapter *padapter,

			   struct recv_frame *precv_frame);

unsigned int OnAction_p2p(struct adapter *padapter,

			  struct recv_frame *precv_frame);