Commit b9950e7b authored by Fabio M. De Francesco's avatar Fabio M. De Francesco Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove a buffer from rtw_writeN() 



Remove the unnecessary buffer "u8 buf[VENDOR_CMD_MAX_DATA_LEN]" and
pass directly "data" to usbctrl_vendorreq().

Co-developed-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-10-fmdefrancesco@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a3c19001

drivers/staging/r8188eu/hal/usb_ops_linux.c

+1 −3
Original line number Diff line number Diff line
@@ -171,14 +171,12 @@ int rtw_writeN(struct adapter *adapter, u32 addr, u32 length, u8 *data) 
	struct io_priv *io_priv = &adapter->iopriv;

	struct intf_hdl *intf = &io_priv->intf;

	u16 value = addr & 0xffff;

	u8 buf[VENDOR_CMD_MAX_DATA_LEN] = {0};

	int ret;



	if (length > VENDOR_CMD_MAX_DATA_LEN)

		return _FAIL;



	memcpy(buf, data, length);

	ret = usbctrl_vendorreq(intf, value, buf, (length & 0xffff), REALTEK_USB_VENQT_WRITE);

	ret = usbctrl_vendorreq(intf, value, data, (length & 0xffff), REALTEK_USB_VENQT_WRITE);



	return RTW_STATUS_CODE(ret);

}