Commit cf32e41f authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by David Sterba
Browse files

btrfs: use __bio_add_page to add single a page in rbio_add_io_sector 



The btrfs raid56 sector submission code uses bio_add_page() to add a
page to a newly created bio. bio_add_page() can fail, but the return
value is never checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Reviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 078e4cf5

fs/btrfs/raid56.c

+1 −1
Original line number Diff line number Diff line
@@ -1102,7 +1102,7 @@ static int rbio_add_io_sector(struct btrfs_raid_bio *rbio, 
	bio->bi_iter.bi_sector = disk_start >> 9;

	bio->bi_private = rbio;



	bio_add_page(bio, sector->page, sectorsize, sector->pgoff);

	__bio_add_page(bio, sector->page, sectorsize, sector->pgoff);

	bio_list_add(bio_list, bio);

	return 0;

}