treewide: use get_random_u32_{above,below}() instead of manual loop
These cases were done with this Coccinelle: @@ expression E; identifier I; @@ - do { ... when != I - I = get_random_u32(); ... when != I - } while (I > E); + I = get_random_u32_below(E + 1); @@ expression E; identifier I; @@ - do { ... when != I - I = get_random_u32(); ... when != I - } while (I >= E); + I = get_random_u32_below(E); @@ expression E; identifier I; @@ - do { ... when != I - I = get_random_u32(); ... when != I - } while (I < E); + I = get_random_u32_above(E - 1); @@ expression E; identifier I; @@ - do { ... when != I - I = get_random_u32(); ... when != I - } while (I <= E); + I = get_random_u32_above(E); @@ identifier I; @@ - do { ... when != I - I = get_random_u32(); ... when != I - } while (!I); + I = get_random_u32_above(0); @@ identifier I; @@ - do { ... when != I - I = get_random_u32(); ... when != I - } while (I == 0); + I = get_random_u32_above(0); @@ expression E; @@ - E + 1 + get_random_u32_below(U32_MAX - E) + get_random_u32_above(E) Reviewed-by:Kees Cook <keescook@chromium.org> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Jason A. Donenfeld <Jason@zx2c4.com>
Showing
- fs/ext4/mmp.c 1 addition, 7 deletionsfs/ext4/mmp.c
- lib/test_fprobe.c 1 addition, 4 deletionslib/test_fprobe.c
- lib/test_kprobes.c 1 addition, 4 deletionslib/test_kprobes.c
- net/ipv6/output_core.c 1 addition, 7 deletionsnet/ipv6/output_core.c
- net/vmw_vsock/af_vsock.c 1 addition, 2 deletionsnet/vmw_vsock/af_vsock.c
Loading
Please register or sign in to comment