Skip to content
Snippets Groups Projects
Commit d2921096 authored by Colin Ian King's avatar Colin Ian King Committed by Chris Wilson
Browse files

drm/i915/selftest: fix an error return path where err is not being set


There is an error condition where err is not being set and an uninitialized
garbage value in err is being returned.  Fix this by assigning err to an
appropriate error return value before taking the error exit path.

Addresses-Coverity: ("Uninitialized scalar value")
Fixes: ed2690a9 ("drm/i915/selftest: Check that GPR are restored across noa_wait")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20200713142551.423649-1-colin.king@canonical.com
parent 4fe6abb8
No related branches found
No related tags found
No related merge requests found
......@@ -328,6 +328,7 @@ static int live_noa_gpr(void *arg)
/* Fill the 16 qword [32 dword] GPR with a known unlikely value */
cs = intel_ring_begin(rq, 2 * 32 + 2);
if (IS_ERR(cs)) {
err = PTR_ERR(cs);
i915_request_add(rq);
goto out_rq;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment