sched/wait: Fix the signal handling fix
Jan Stancek reported that I wrecked things for him by fixing things for Vladimir :/ His report was due to an UNINTERRUPTIBLE wait getting -EINTR, which should not be possible, however my previous patch made this possible by unconditionally checking signal_pending(). We cannot use current->state as was done previously, because the instruction after the store to that variable it can be changed. We must instead pass the initial state along and use that. Fixes: 68985633 ("sched/wait: Fix signal handling in bit wait helpers") Reported-by:Jan Stancek <jstancek@redhat.com> Reported-by:
Chris Mason <clm@fb.com> Tested-by:
Jan Stancek <jstancek@redhat.com> Tested-by:
Vladimir Murzin <vladimir.murzin@arm.com> Tested-by:
Chris Mason <clm@fb.com> Reviewed-by:
Paul Turner <pjt@google.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: tglx@linutronix.de Cc: Oleg Nesterov <oleg@redhat.com> Cc: hpa@zytor.com Signed-off-by:
Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- fs/cifs/inode.c 3 additions, 3 deletionsfs/cifs/inode.c
- fs/nfs/inode.c 3 additions, 3 deletionsfs/nfs/inode.c
- fs/nfs/internal.h 1 addition, 1 deletionfs/nfs/internal.h
- fs/nfs/pagelist.c 1 addition, 1 deletionfs/nfs/pagelist.c
- fs/nfs/pnfs.c 2 additions, 2 deletionsfs/nfs/pnfs.c
- include/linux/wait.h 5 additions, 5 deletionsinclude/linux/wait.h
- kernel/sched/wait.c 10 additions, 10 deletionskernel/sched/wait.c
- net/sunrpc/sched.c 3 additions, 3 deletionsnet/sunrpc/sched.c
Loading
Please register or sign in to comment