Commit ec14d90d authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Lee Jones
Browse files

mfd: tps65912: Make tps65912_device_exit() return void 



Up to now tps65912_device_exit() returns zero unconditionally. Make it
return void instead which makes it easier to see in the callers that
there is no error to handle.

Also the return value of i2c and spi remove callbacks is ignored anyway.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20211012153945.2651412-11-u.kleine-koenig@pengutronix.de
parent 356bbaba

drivers/mfd/tps65912-core.c

+1 −3
Original line number Diff line number Diff line
@@ -115,11 +115,9 @@ int tps65912_device_init(struct tps65912 *tps) 
}

EXPORT_SYMBOL_GPL(tps65912_device_init);



int tps65912_device_exit(struct tps65912 *tps)

void tps65912_device_exit(struct tps65912 *tps)

{

	regmap_del_irq_chip(tps->irq, tps->irq_data);



	return 0;

}

EXPORT_SYMBOL_GPL(tps65912_device_exit);

drivers/mfd/tps65912-i2c.c

+3 −1
Original line number Diff line number Diff line
@@ -55,7 +55,9 @@ static int tps65912_i2c_remove(struct i2c_client *client) 
{

	struct tps65912 *tps = i2c_get_clientdata(client);



	return tps65912_device_exit(tps);

	tps65912_device_exit(tps);



	return 0;

}



static const struct i2c_device_id tps65912_i2c_id_table[] = {

drivers/mfd/tps65912-spi.c

+3 −1
Original line number Diff line number Diff line
@@ -54,7 +54,9 @@ static int tps65912_spi_remove(struct spi_device *spi) 
{

	struct tps65912 *tps = spi_get_drvdata(spi);



	return tps65912_device_exit(tps);

	tps65912_device_exit(tps);



	return 0;

}



static const struct spi_device_id tps65912_spi_id_table[] = {

include/linux/mfd/tps65912.h

+1 −1
Original line number Diff line number Diff line
@@ -322,6 +322,6 @@ struct tps65912 { 
extern const struct regmap_config tps65912_regmap_config;



int tps65912_device_init(struct tps65912 *tps);

int tps65912_device_exit(struct tps65912 *tps);

void tps65912_device_exit(struct tps65912 *tps);



#endif /*  __LINUX_MFD_TPS65912_H */