drm/i915/display: Make WARN* drm specific where drm_device ptr is available
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device or drm_i915_private struct pointer is readily available. The conversion was done automatically with below coccinelle semantic patch. checkpatch errors/warnings are fixed manually. @rule1@ identifier func, T; @@ func(...) { ... struct drm_device *T = ...; <... ( -WARN( +drm_WARN(T, ...) | -WARN_ON( +drm_WARN_ON(T, ...) | -WARN_ONCE( +drm_WARN_ONCE(T, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(T, ...) ) ...> } @rule2@ identifier func, T; @@ func(struct drm_device *T,...) { <... ( -WARN( +drm_WARN(T, ...) | -WARN_ON( +drm_WARN_ON(T, ...) | -WARN_ONCE( +drm_WARN_ONCE(T, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(T, ...) ) ...> } @rule3@ identifier func, T; @@ func(...) { ... struct drm_i915_private *T = ...; <+... ( -WARN( +drm_WARN(&T->drm, ...) | -WARN_ON( +drm_WARN_ON(&T->drm, ...) | -WARN_ONCE( +drm_WARN_ONCE(&T->drm, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(&T->drm, ...) ) ...+> } @rule4@ identifier func, T; @@ func(struct drm_i915_private *T,...) { <+... ( -WARN( +drm_WARN(&T->drm, ...) | -WARN_ON( +drm_WARN_ON(&T->drm, ...) | -WARN_ONCE( +drm_WARN_ONCE(&T->drm, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(&T->drm, ...) ) ...+> } Signed-off-by:Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> Signed-off-by:
Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200128181603.27767-20-pankaj.laxminarayan.bharadiya@intel.com
Showing
- drivers/gpu/drm/i915/display/intel_atomic.c 4 additions, 2 deletionsdrivers/gpu/drm/i915/display/intel_atomic.c
- drivers/gpu/drm/i915/display/intel_bios.c 6 additions, 4 deletionsdrivers/gpu/drm/i915/display/intel_bios.c
- drivers/gpu/drm/i915/display/intel_bw.c 2 additions, 1 deletiondrivers/gpu/drm/i915/display/intel_bw.c
- drivers/gpu/drm/i915/display/intel_color.c 2 additions, 1 deletiondrivers/gpu/drm/i915/display/intel_color.c
- drivers/gpu/drm/i915/display/intel_combo_phy.c 1 addition, 1 deletiondrivers/gpu/drm/i915/display/intel_combo_phy.c
- drivers/gpu/drm/i915/display/intel_connector.c 2 additions, 1 deletiondrivers/gpu/drm/i915/display/intel_connector.c
- drivers/gpu/drm/i915/display/intel_dp_mst.c 6 additions, 4 deletionsdrivers/gpu/drm/i915/display/intel_dp_mst.c
- drivers/gpu/drm/i915/display/intel_dpio_phy.c 2 additions, 1 deletiondrivers/gpu/drm/i915/display/intel_dpio_phy.c
- drivers/gpu/drm/i915/display/intel_dsb.c 3 additions, 3 deletionsdrivers/gpu/drm/i915/display/intel_dsb.c
- drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c 1 addition, 1 deletiondrivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.c
- drivers/gpu/drm/i915/display/intel_dsi_vbt.c 3 additions, 2 deletionsdrivers/gpu/drm/i915/display/intel_dsi_vbt.c
- drivers/gpu/drm/i915/display/intel_gmbus.c 2 additions, 1 deletiondrivers/gpu/drm/i915/display/intel_gmbus.c
- drivers/gpu/drm/i915/display/intel_hotplug.c 4 additions, 3 deletionsdrivers/gpu/drm/i915/display/intel_hotplug.c
- drivers/gpu/drm/i915/display/intel_lpe_audio.c 1 addition, 1 deletiondrivers/gpu/drm/i915/display/intel_lpe_audio.c
- drivers/gpu/drm/i915/display/intel_lvds.c 4 additions, 3 deletionsdrivers/gpu/drm/i915/display/intel_lvds.c
- drivers/gpu/drm/i915/display/intel_opregion.c 4 additions, 3 deletionsdrivers/gpu/drm/i915/display/intel_opregion.c
- drivers/gpu/drm/i915/display/intel_pipe_crc.c 4 additions, 3 deletionsdrivers/gpu/drm/i915/display/intel_pipe_crc.c
- drivers/gpu/drm/i915/display/intel_sprite.c 3 additions, 2 deletionsdrivers/gpu/drm/i915/display/intel_sprite.c
- drivers/gpu/drm/i915/display/intel_vdsc.c 1 addition, 1 deletiondrivers/gpu/drm/i915/display/intel_vdsc.c
- drivers/gpu/drm/i915/display/vlv_dsi.c 1 addition, 1 deletiondrivers/gpu/drm/i915/display/vlv_dsi.c
Loading
Please register or sign in to comment