Commit f78fc874 authored May 01, 2005 by Vinay K Nallamothu Committed by Linus Torvalds May 01, 2005

[PATCH] attribute placement fixes



The variable attributes "packed" and "align" when used with struct, should
have the following order:

struct ... {...} __attribute__((packed)) var;

This patch fixes few instances where the variable and attributes are placed
the other way around and had no effect.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent e49332bd

drivers/net/gt96100eth.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -214,7 +214,7 @@ typedef struct {
		u32 cmdstat;
		u32 next;
		u32 buff_ptr;
		} gt96100_td_t __attribute__ ((packed));
		} __attribute__ ((packed)) gt96100_td_t;

		typedef struct {
		#ifdef DESC_BE
		@@ -227,7 +227,7 @@ typedef struct {
		u32 cmdstat;
		u32 next;
		u32 buff_ptr;
		} gt96100_rd_t __attribute__ ((packed));
		} __attribute__ ((packed)) gt96100_rd_t;


		/* Values for the Tx command-status descriptor entry. */

include/asm-m68knommu/MC68328.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -993,7 +993,7 @@ typedef volatile struct {
		volatile unsigned short int pad1;
		volatile unsigned short int pad2;
		volatile unsigned short int pad3;
		} m68328_uart __attribute__((packed));
		} __attribute__((packed)) m68328_uart;


		/**********

include/asm-m68knommu/MC68EZ328.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -815,7 +815,7 @@ typedef volatile struct {
		volatile unsigned short int nipr;
		volatile unsigned short int pad1;
		volatile unsigned short int pad2;
		} m68328_uart __attribute__((packed));
		} __attribute__((packed)) m68328_uart;


		/**********

include/asm-m68knommu/MC68VZ328.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -909,7 +909,7 @@ typedef struct {
		volatile unsigned short int nipr;
		volatile unsigned short int hmark;
		volatile unsigned short int unused;
		} m68328_uart __attribute__((packed));
		} __attribute__((packed)) m68328_uart;