Skip to content
Snippets Groups Projects
Commit fed08d03 authored by Jody Bruchon's avatar Jody Bruchon Committed by Takashi Iwai
Browse files

ALSA: hda-intel: Avoid divide by zero crash


On my AMD780V chipset, hda_intel.c can crash the kernel with a divide by
zero
for as-yet unknown reasons. A simple check for zero prevents it, though
the problem that causes it remains. Since the workaround is harmless and
won't affect anyone except victims of this bug, it should be safe;
moreover,
because this crash can be triggered by a user-mode application, there are
denial of service implications on the systems affected by the bug without
the patch.

Signed-off-by: default avatarJody Bruchon <jody@nctritech.com>
Cc: <stable@kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9492837a
No related branches found
No related tags found
No related merge requests found
...@@ -1893,6 +1893,12 @@ static int azx_position_ok(struct azx *chip, struct azx_dev *azx_dev) ...@@ -1893,6 +1893,12 @@ static int azx_position_ok(struct azx *chip, struct azx_dev *azx_dev)
if (!bdl_pos_adj[chip->dev_index]) if (!bdl_pos_adj[chip->dev_index])
return 1; /* no delayed ack */ return 1; /* no delayed ack */
if (azx_dev->period_bytes == 0) {
printk(KERN_WARNING
"hda-intel: Divide by zero was avoided "
"in azx_dev->period_bytes.\n");
return 0;
}
if (pos % azx_dev->period_bytes > azx_dev->period_bytes / 2) if (pos % azx_dev->period_bytes > azx_dev->period_bytes / 2)
return 0; /* NG - it's below the period boundary */ return 0; /* NG - it's below the period boundary */
return 1; /* OK, it's fine */ return 1; /* OK, it's fine */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment