Skip to content
  1. Jan 12, 2011
    • Koen Kooi's avatar
      omap3: beaglexm: fix power on of DVI · 1bd9ef19
      Koen Kooi authored
      
      
      TFP410 DVI chip is used to provide display out.
      This chip is controlled by 2 lines:
      LDO which supplies the power is controlled over gpio + 2
      and the enable of the chip itself is done over gpio + 1
      NOTE: the LDO is necessary for LED, serial blocks as well.
      
      gpio + 1 was used to sense USB overcurrent in vanilla beagle.
      
      Without this fix, the display would not function as the LDO
      remains shut down.
      
      [nm@ti.com: split up, added descriptive changelogs]
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarKoen Kooi <koen@beagleboard.org>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      1bd9ef19
  2. Jan 11, 2011
  3. Jan 10, 2011
  4. Jan 07, 2011
    • Santosh Shilimkar's avatar
      omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg' · 56a6a19d
      Santosh Shilimkar authored
      
      
      omap2plus_defocnfig build breaks when customised with only ARCH_OMAP4
      selected. This is because common files make references to the functions
      which are defined only for omap2xxx and omap3xxx.
      
       LD      .tmp_vmlinux1
      arch/arm/mach-omap2/built-in.o: In function `pm_dbg_regset_store':
      arch/arm/mach-omap2/pm-debug.c:335: undefined reference to `omap2_prm_read_mod_reg'
      arch/arm/mach-omap2/built-in.o: In function `omap2_pm_dump':
      arch/arm/mach-omap2/pm-debug.c:121: undefined reference to `omap2_prm_read_mod_reg'
      arch/arm/mach-omap2/pm-debug.c:123: undefined reference to `omap2_prm_read_mod_reg'
      arch/arm/mach-omap2/pm-debug.c:124: undefined reference to `omap2_prm_read_mod_reg'
      arch/arm/mach-omap2/pm-debug.c:125: undefined reference to `omap2_prm_read_mod_reg'
      arch/arm/mach-omap2/built-in.o: In function `omap_prcm_arch_reset':
      arch/arm/mach-omap2/prcm.c:106: undefined reference to `omap2_prm_set_mod_reg_bits'
      arch/arm/mach-omap2/prcm.c:108: undefined reference to `omap2_prm_read_mod_reg'
      arch/arm/mach-omap2/built-in.o: In function `omap_prcm_get_reset_sources':
      arch/arm/mach-omap2/prcm.c:53: undefined reference to `omap2_prm_read_mod_reg'
      arch/arm/mach-omap2/built-in.o: In function `clkdm_clear_all_wkdeps':
      arch/arm/mach-omap2/clockdomain.c:545: undefined reference to `omap2_prm_clear_mod_reg_bits'
      arch/arm/mach-omap2/built-in.o: In function `clkdm_del_wkdep':
      arch/arm/mach-omap2/clockdomain.c:475: undefined reference to `omap2_prm_clear_mod_reg_bits'
      arch/arm/mach-omap2/built-in.o: In function `clkdm_read_wkdep':
      arch/arm/mach-omap2/clockdomain.c:511: undefined reference to `omap2_prm_read_mod_bits_shift'
      arch/arm/mach-omap2/built-in.o: In function `clkdm_add_wkdep':
      arch/arm/mach-omap2/clockdomain.c:440: undefined reference to `omap2_prm_set_mod_reg_bits'
      make: *** [.tmp_vmlinux1] Error 1
      
      This patch adds stubs for these functions so that build continues to work.
      
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      Acked-by: default avatarPaul Walmsley <paul@pwsan.com>
      Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
      56a6a19d
    • Santosh Shilimkar's avatar
      omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask · 30299137
      Santosh Shilimkar authored
      
      
      struct clockdomain member clktrctrl_mask is available for only for OMAP2
      and OMAP3 architectures. Technially it is also used only for these archs
      but this breaks the build with custom OMAP4 configuration.
      
       CC      arch/arm/mach-omap2/clockdomain.o
      arch/arm/mach-omap2/clockdomain.c: In function '_enable_hwsup':
      arch/arm/mach-omap2/clockdomain.c:251: error: 'struct clockdomain' has no member named 'clktrctrl_mask'
      arch/arm/mach-omap2/clockdomain.c:254: error: 'struct clockdomain' has no member named 'clktrctrl_mask'
      arch/arm/mach-omap2/clockdomain.c: In function '_disable_hwsup':
      arch/arm/mach-omap2/clockdomain.c:277: error: 'struct clockdomain' has no member named 'clktrctrl_mask'
      arch/arm/mach-omap2/clockdomain.c:280: error: 'struct clockdomain' has no member named 'clktrctrl_mask'
      arch/arm/mach-omap2/clockdomain.c: In function 'omap2_clkdm_sleep':
      arch/arm/mach-omap2/clockdomain.c:744: error: 'struct clockdomain' has no member named 'clktrctrl_mask'
      arch/arm/mach-omap2/clockdomain.c: In function 'omap2_clkdm_wakeup':
      arch/arm/mach-omap2/clockdomain.c:789: error: 'struct clockdomain' has no member named 'clktrctrl_mask'
      arch/arm/mach-omap2/clockdomain.c: In function 'omap2_clkdm_clk_enable':
      arch/arm/mach-omap2/clockdomain.c:922: error: 'struct clockdomain' has no member named 'clktrctrl_mask'
      arch/arm/mach-omap2/clockdomain.c:926: error: 'struct clockdomain' has no member named 'clktrctrl_mask'
      arch/arm/mach-omap2/clockdomain.c: In function 'omap2_clkdm_clk_disable':
      arch/arm/mach-omap2/clockdomain.c:994: error: 'struct clockdomain' has no member named 'clktrctrl_mask'
      arch/arm/mach-omap2/clockdomain.c:998: error: 'struct clockdomain' has no member named 'clktrctrl_mask'
      make[1]: *** [arch/arm/mach-omap2/clockdomain.o] Error 1
      make: *** [arch/arm/mach-omap2] Error 2
      
      Fix the build break by dropping the #ifdef as suggested by Paul Walmsley
      
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      Acked-by: default avatarPaul Walmsley <paul@pwsan.com>
      Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
      30299137
    • Nishanth Menon's avatar
      omap2+: pm_bus: make functions used as pointers as static · b97c374d
      Nishanth Menon authored
      
      
      omap_pm_runtime_suspend and omap_pm_runtime_resume are used
      as function pointers and does not really need to be exposed
      to the world.
      
      Fixes sparse warnings:
      arch/arm/mach-omap2/pm_bus.c:23:5: warning: symbol 'omap_pm_runtime_suspend' was not declared. Should it be static?
      arch/arm/mach-omap2/pm_bus.c:40:5: warning: symbol 'omap_pm_runtime_resume' was not declared. Should it be static?
      
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
      b97c374d
    • Nishanth Menon's avatar
      OMAP2+: TWL: include pm header for init protos · dda0aea7
      Nishanth Menon authored
      
      
      twl_init functions are declared in pm.h and used in pm.c
      pm.h header defining the protos need to be included to
      ensure that omap_twl.c has consistent function definition.
      This fixes sparse warning:
      arch/arm/mach-omap2/omap_twl.c:237:12: warning: symbol 'omap4_twl_init' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_twl.c:256:12: warning: symbol 'omap3_twl_init' was not declared. Should it be static?
      
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
      dda0aea7
    • Nishanth Menon's avatar
      OMAP2+: TWL: make conversion routines static · c84ff1cc
      Nishanth Menon authored
      
      
      The uv_to_vsel, vsel_to_uv functions don't need to be exposed to the
      world as they are used as function pointers. make them static.
      
      Fixes sparse warnings:
      arch/arm/mach-omap2/omap_twl.c:63:15: warning: symbol 'twl4030_vsel_to_uv' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_twl.c:68:4: warning: symbol 'twl4030_uv_to_vsel' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_twl.c:73:15: warning: symbol 'twl6030_vsel_to_uv' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_twl.c:105:4: warning: symbol 'twl6030_uv_to_vsel' was not declared. Should it be static?
      
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
      c84ff1cc
    • Nishanth Menon's avatar
      OMAP3+: sr_device: include pm header · d0eadf6d
      Nishanth Menon authored
      
      
      omap_enable_smartreflex_on_init is meant to be used by boards
      which would like to have SR enabled by default on the platform, while
      omap_devinit_smartreflex is used by pm code, the protos are defined
      in pm.h. This header should be included to ensure that sr_device
      function definitions match the prototypes.
      
      including pm.h fixes the sparse warnings (with CONFIG_OMAP_SMARTREFLEX=y):
      arch/arm/mach-omap2/sr_device.c:138:13: warning: symbol 'omap_enable_smartreflex_on_init' was not declared. Should it be static?
      arch/arm/mach-omap2/sr_device.c:143:12: warning: symbol 'omap_devinit_smartreflex' was not declared. Should it be static?
      
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
      d0eadf6d
    • Nishanth Menon's avatar
      omap2+: wdt: trivial sparse fixes · a9b365bd
      Nishanth Menon authored
      
      
      omap2_wd_timer_disable is declared in wdtimer.h and used by hwmod
      function pointers for usage, the header inclusion is necessary
      to ensure that the prototype and function remains consistent.
      omap_wdt_latency is passed as a pointer and does not need global scope
      
      Fixes sparse warnings:
      arch/arm/mach-omap2/devices.c:981:31: warning: symbol 'omap_wdt_latency' was not declared. Should it be static?
      arch/arm/mach-omap2/wd_timer.c:27:5: warning: symbol 'omap2_wd_timer_disable' was not declared. Should it be static?
      
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      a9b365bd
    • Nishanth Menon's avatar
      omap3: igep3: make igep3_flash_init static · 2393608a
      Nishanth Menon authored
      
      
      igep3_flash_init is not used beyond the scope of the file, make it
      static instead.
      
      Fixes sparse warning:
      arch/arm/mach-omap2/board-igep0030.c:106:13: warning: symbol 'igep3_flash_init' was not declared. Should it be static?
      
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      2393608a
    • Nishanth Menon's avatar
      omap3: zoom: use static for pointer passing · 0ce3bb72
      Nishanth Menon authored
      
      
      omap_zoom_wlan_data and zoom2_set_hs_extmute are not used beyond
      the scope of zoom-peripherals directly, instead pointers are used.
      make them static instead.
      
      Fixes sparse warnings:
      arch/arm/mach-omap2/board-zoom-peripherals.c:193:29: warning: symbol 'omap_zoom_wlan_data' was not declared. Should it be static?
      arch/arm/mach-omap2/board-zoom-peripherals.c:245:6: warning: symbol 'zoom2_set_hs_extmute' was not declared. Should it be static?
      
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      0ce3bb72
    • Nishanth Menon's avatar
      omap3|4: mux: make local structures static · bcb52693
      Nishanth Menon authored
      
      
      Mux data is passed by pointers to mux.c from the SoC specific
      mux file, these variables dont really need to be global scope.
      
      This fixes the following sparse warnings:
      arch/arm/mach-omap2/mux44xx.c:547:29: warning: symbol 'omap4_core_cbl_ball' was not declared. Should it be static?
      arch/arm/mach-omap2/mux44xx.c:1265:29: warning: symbol 'omap4_core_cbs_ball' was not declared. Should it be static?
      arch/arm/mach-omap2/mux44xx.c:1549:29: warning: symbol 'omap4_wkup_cbl_cbs_ball' was not declared. Should it be static?
      
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      bcb52693
    • Aaro Koskinen's avatar
      arm: mach-omap2: mux: fix buffer overrun · 30833142
      Aaro Koskinen authored
      
      
      memcpy() copies 8 bytes too much (omap_mux_entry vs. omap_mux). Correct
      by replacing memcpy() with struct assignment, which is safer.
      
      Signed-off-by: default avatarAaro Koskinen <aaro.koskinen@nokia.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      30833142
  5. Dec 24, 2010
  6. Dec 23, 2010
  7. Dec 22, 2010
Loading