Skip to content
  1. Sep 24, 2015
    • Takashi Iwai's avatar
      ALSA: hda - Disable power_save_node for Thinkpads · 7f57d803
      Takashi Iwai authored 
      Lenovo Thinkpads with recent Realtek codecs seem suffering from click
noises at power transition since the introduction of widget power
saving in 4.1 kernel.  Although this might be solved by some delays in
appropriate points, as a quick workaround, just disable the
power_save_node feature for now.  The gain it gives is relatively
small, and this makes the situation back to pre 4.1 time.

This patch ended up with a bit more code changes than usual because
the existing fixup for Thinkpads is highly chained.  Instead of adding
yet another chain, combine a few of them into a single fixup entry, as
a gratis cleanup.

Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=943982


Cc: <stable@vger.kernel.org> # v4.1+
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      7f57d803
    • Takashi Iwai's avatar
      ALSA: hda/tegra - async probe for avoiding module loading deadlock · 83510441
      Takashi Iwai authored 
      

The Tegra HD-audio controller driver causes deadlocks when loaded as a
module since the driver invokes request_module() at binding with the
codec driver.  This patch works around it by deferring the probe in a
work like Intel HD-audio controller driver does.  Although hovering
the codec probe stuff into udev would be a better solution, it may
cause other regressions, so let's try this band-aid fix until the more
proper solution gets landed.

Reported-by: default avatarThierry Reding <treding@nvidia.com>
Tested-by: default avatarThierry Reding <treding@nvidia.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      83510441
  3. Sep 05, 2015
  5. Sep 04, 2015
  7. Sep 03, 2015
  9. Sep 02, 2015
  11. Aug 26, 2015
  13. Aug 25, 2015
    • Takashi Iwai's avatar
      ALSA: hda - Refresh sysfs at snd_hda_codec_update_widgets() · 9dcc144b
      Takashi Iwai authored 
      

In the commit [fa4f18b4: ALSA: hda - Refresh widgets sysfs at
probing Haswell+ HDMI codecs], snd_hdac_refresh_widget_sysfs() is
explicitly called in the codec driver.  But this results in refreshing
twice, as snd_hdac_refresh_widget_sysfs() itself calls
snd_hdac_refresh_widgets() function.

Instead, we can replace the call in snd_hda_codec_update_widgets()
with snd_hdac_refresh_widget_sysfs().  This also fixes the missing
sysfs update for ca0132, too.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      9dcc144b
    • Takashi Iwai's avatar
      ALSA: hda - Fix path power activation · c7cd0ef6
      Takashi Iwai authored 
      The widget power-saving code tries to turn up/down the power of each
widget in the I/O paths that are modified at each jack plug/unplug.
The recent report revealed that the power activation leaves some
widgets unpowered after plugging.  This is because
snd_hda_activate_path() turns on path->active flag at the end of the
function while the path power management is done before that.  Then
it's regarded as if nothing is active, and the driver turns off the
power.

The fix is simply to set the flag at the beginning of the function,
before trying to power up.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=102521


Cc: <stable@vger.kernel.org> [v4.1+]
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      c7cd0ef6
    • Takashi Iwai's avatar
      ALSA: hda - Check all inputs for is_active_nid_for_any() · 9d2b48f7
      Takashi Iwai authored 
      The is_active_nid_for_any() function in the generic parser is supposed
to check all connections from/to the given widget, but the current
code checks only the first input connection (index = 0).

This patch corrects the code to check all inputs by passing -1 to
index argument.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=102521


Cc: <stable@vger.kernel.org> [v4.1+]
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      9d2b48f7
  15. Aug 24, 2015
  17. Aug 22, 2015
  19. Aug 21, 2015
  21. Aug 19, 2015
  23. Aug 17, 2015
  25. Aug 13, 2015
  27. Aug 10, 2015
    • Takashi Iwai's avatar
      ALSA: hda - Fix pin config and mapping on Alienware 15 · fe14f39e
      Takashi Iwai authored 
      Alienware 15 has CA0132 codec for its onboard sound, but the pin
config and mapping seem quite different from other Creative boards.
This patch corrects them, at least, for providing the right headphone
and mic jack notification, as well as removing the non-existing SPDIF
pins.

Even with this fix, not all stuff works perfectly yet, mainly because
of the badly written ca0132 driver code -- it has too many implicit
assumptions of pin configs and maps.  Nevertheless, this is a small
good step forward.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=101981


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      fe14f39e
    • Mark Brown's avatar
      ALSA: echoaudio: Use standard C definitions of true and false · 3f6175ec
      Mark Brown authored 
      

The echoaudio locally defines TRUE and FALSE.  Not only is this
redundant given that C now has a boolean type it results in lots of
warnings as other headers also define these macros, causing duplicate
definitions.  Fix this by removing the local defines and converting all
local users to use the standard C true and false instead, simply
removing the macros is less safe due to implicit inclusion of the other
definitons.

[fixed overlooked replacement of FALSE by tiwai]

Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      3f6175ec
  29. Aug 05, 2015
  31. Aug 03, 2015
  33. Jul 30, 2015
  35. Jul 29, 2015
  37. Jul 27, 2015
  39. Jul 25, 2015
  41. Jul 22, 2015
  43. Jul 21, 2015