Skip to content
Commit f16a005c authored by Randy Dunlap's avatar Randy Dunlap Committed by Herbert Xu
Browse files

crypto: x86 - eliminate anonymous module_init & module_exit



Eliminate anonymous module_init() and module_exit(), which can lead to
confusion or ambiguity when reading System.map, crashes/oops/bugs,
or an initcall_debug log.

Give each of these init and exit functions unique driver-specific
names to eliminate the anonymous names.

Example 1: (System.map)
 ffffffff832fc78c t init
 ffffffff832fc79e t init
 ffffffff832fc8f8 t init

Example 2: (initcall_debug log)
 calling  init+0x0/0x12 @ 1
 initcall init+0x0/0x12 returned 0 after 15 usecs
 calling  init+0x0/0x60 @ 1
 initcall init+0x0/0x60 returned 0 after 2 usecs
 calling  init+0x0/0x9a @ 1
 initcall init+0x0/0x9a returned 0 after 74 usecs

Fixes: 64b94cea ("crypto: blowfish - add x86_64 assembly implementation")
Fixes: 676a3804 ("crypto: camellia-x86_64 - module init/exit functions should be static")
Fixes: 0b95ec56 ("crypto: camellia - add assembler implementation for x86_64")
Fixes: 56d76c96 ("crypto: serpent - add AVX2/x86_64 assembler implementation of serpent cipher")
Fixes: b9f535ff ("[CRYPTO] twofish: i586 assembly version")
Fixes: ff0a70fe ("crypto: twofish-x86_64-3way - module init/exit functions should be static")
Fixes: 8280daad ("crypto: twofish - add 3-way parallel x86_64 assembler implemention")
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: Joachim Fritschi <jfritschi@freenet.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: x86@kernel.org
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 4cda2f4a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment