- Jun 11, 2018
-
-
Robert Jarzmik authored
It is not mandatory that platform data is passed along the ac97 codec. Actually there are configuration without a battery connected to the ADC of the codec. This is for example the case for the PXA zylonite platform, so fix the NULL dereferencing by adding a test. Fixes: a5c6951c ("mfd: wm97xx-core: core support for wm97xx Codec") Signed-off-by:
Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by:
Lee Jones <lee.jones@linaro.org>
-
- Jun 04, 2018
-
-
Stephen Boyd authored
If the feature query fails during this driver's probe, we memset the features bits to 0, but then we continue to overwrite that with whatever junk we read back when the feature probing failed. In the case of a SPI device, it may be complete junk, causing the caller of this function to think certain features are present when they aren't. Don't copy over the bad message on failure so we can fail more gracefully. Fixes: e4244ebd ("platform/chrome: Introduce a new function to check EC features.") Signed-off-by:
Stephen Boyd <swboyd@chromium.org> Acked-by:
Benson Leung <bleung@chromium.org> Signed-off-by:
-
Gwendal Grignou authored
Use dev_kzmalloc, remove .release entry point. Signed-off-by:
Gwendal Grignou <gwendal@chromium.org> Signed-off-by:
-
Jarkko Nikula authored
Intel Cannon Lake PCH has much higher 216 MHz input clock to LPSS I2C than Sunrisepoint which uses 120 MHz. Preliminary information was that both share the same clock rate but actual silicon implements elevated rate for better support for 3.4 MHz high-speed I2C. This incorrect input clock rate results too high I2C bus clock in case ACPI doesn't provide tuned I2C timing parameters since I2C host controller driver calculates them from input clock rate. Fix this by using the correct rate. We still share the same 230 ns SDA hold time value than Sunrisepoint. Cc: stable@vger.kernel.org Fixes: b418bbff ("mfd: intel-lpss: Add Intel Cannonlake PCI IDs") Reported-by:
Jian-Hong Pan <jian-hong@endlessm.com> Reported-by:
Chris Chiu <chiu@endlessm.com> Reported-by:
Daniel Drake <drake@endlessm.com> Signed-off-by:
Jarkko Nikula <jarkko.nikula@linux.intel.com> Reviewed-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by:
Mika Westerberg <mika.westerberg@linux.intel.com> Tested-by:
-
Robert Jarzmik authored
The MMC framework requires the ocr_mask to be provided. Without it, the SD card is not detected, especially on the hx4700 platform. Signed-off-by:
-
Colin Ian King authored
Trivial fix to spelling mistake in dev_err message text Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Yisheng Xie authored
match_string() returns the index of an array for a matching string, which can be used intead of open coded variant. Signed-off-by:
Yisheng Xie <xieyisheng1@huawei.com> Acked-by:
Tony Lindgren <tony@atomide.com> Reviewed-by:
Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by:
-
Fabrice Gasnier authored
This is seen when COMPILE_TEST=y and MFD_STM32_TIMERS=n. drivers/pwm/pwm-stm32.o: In function 'stm32_pwm_raw_capture': pwm-stm32.c:... undefined reference to 'stm32_timers_dma_burst_read' Fixes: 0c660980 ("mfd: stm32-timers: Add support for DMAs") Signed-off-by:
Fabrice Gasnier <fabrice.gasnier@st.com> Reported-by:
Randy Dunlap <rdunlap@infradead.org> Tested-by:
-
Fabrice Gasnier authored
This removes build warning when COMPILE_TEST=y and MFD_STM32_TIMERS=n in drivers/pwm/pwm-stm32.c. In function 'stm32_pwm_capture' 'raw_prd' and 'raw_dty' may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by:
Thierry Reding <thierry.reding@gmail.com> Tested-by:
-
Charles Keepax authored
Signed-off-by:
Charles Keepax <ckeepax@opensource.cirrus.com> Reviewed-by:
Rob Herring <robh@kernel.org> Reviewed-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
-
Marek Vasut authored
Add device tree bindings for the Dialog DA9063L. This is a variant of the DA9063 chip with smaller package, with less LDO regulators and without RTC block. The other properties of the chip are the same, including the content of the chip ID register. Signed-off-by:
Marek Vasut <marek.vasut+renesas@gmail.com> Reviewed-by:
Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by:
-
Andy Shevchenko authored
According to documentation the function has 2 bits for reset while iDMA 64-bit has only one. Rename it accordingly. Note, there is no functional change since we always handle them together. Signed-off-by:
-
Stephen Boyd authored
Add the compatibles and PMIC ids for the pm8005, pm8998, and pmi8998 PMICS found on MSM8998 and SDM845 based platforms. Cc: <devicetree@vger.kernel.org> Signed-off-by:
Doug Anderson <dianders@chromium.org> Signed-off-by:
-
- May 29, 2018
-
-
Andy Shevchenko authored
According to documentation REMAP register has to be programmed in either DMA or PIO mode of the slice. Move the DMA capability check below to let REMAP register be programmed in PIO mode. Cc: stable@vger.kernel.org # 4.3+ Fixes: 4b45efe8 ("mfd: Add support for Intel Sunrisepoint LPSS devices") Signed-off-by:
-
Joseph Lo authored
The cros_ec_i2c driver is still active after it had suspended or before it resumes. Besides that, it also tried to transfer data even after the I2C host had been suspended. This will lead the system to crash. During the test, we also observe that the EC needs to be resumed earlier due to some status polling from the EC FW (e.g. battery status). So we move the PM ops to late stage to make it work normally. Signed-off-by:
Joseph Lo <josephl@nvidia.com> Signed-off-by:
Enric Balletbo i Serra <enric.balletbo@collabora.com> Reviewed-by:
-
Wei-Ning Huang authored
Add ACPI module device table for matching cros-ec devices to load the cros_ec_i2c driver automatically. Signed-off-by:
Wei-Ning Huang <wnhuang@google.com> Acked-by:
-
Daniel Hung-yu Wu authored
Reboot or shutdown during delayed works could corrupt communication with EC and certain I2C controller may not be able to recover from the error state. This patch registers a shutdown callback used to cancel the debugfs log worker thread. Signed-off-by:
Daniel Hung-yu Wu <hywu@chromium.org> Signed-off-by:
-
Enric Balletbo i Serra authored
Check whether this EC instance has RTC host command support and instatiate the RTC driver as a subdevice in such case. Signed-off-by:
-
Douglas Anderson authored
We should stop our worker thread while we're suspended. If we don't then we'll get messages like: cros-ec-spi spi5.0: spi transfer failed: -108 cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108 cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed Signed-off-by:
-
Vincent Palatin authored
Free the IRQ we might have requested when removing the cros_ec device, so we can unload and reload the driver properly. Signed-off-by:
Vincent Palatin <vpalatin@chromium.org> Signed-off-by:
-
Vincent Palatin authored
If we cannot communicate with the EC chip to detect the protocol version and its features, it's very likely useless to continue. Else we will commit all kind of uninformed mistakes (using the wrong protocol, the wrong buffer size, mixing the EC with other chips). Signed-off-by:
-
Sebastian Andrzej Siewior authored
The string.h header file is needed for the memset() definition. The RT build fails because it is not pulled in via other header files. Signed-off-by:
Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by:
Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by:
-
Fabrice Gasnier authored
Add an entry to make myself a maintainer of STM32 timer and lptimer drivers. Signed-off-by:
-
- May 16, 2018
-
-
Lee Jones authored
The COMP1 and COMP2 elements are in 0 and 1 respectively so this code is accessing the wrong elements and one space beyond the end of the array. The "id" variable is never COMP (0) so that code can be removed. Fixes: 6851ad3a ("TPS65911: Comparator: Add comparator driver") Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Kyle Spiers authored
As part of the effort to remove VLAs from the kernel[1], this creates constants for the checksum lengths of CCITT and 8B2C and changes crc_calculated to be the maximum size of a checksum. https://lkml.org/lkml/2018/3/7/621 Signed-off-by:
Kyle Spiers <ksspiers@google.com> Reviewed-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
-
Dan Carpenter authored
In 2012, we changed the tps65910 API and fixed most drivers but forgot to update this one. Fixes: 3f7e8275 ("mfd: Commonize tps65910 regmap access through header") Signed-off-by:
-
Peter Ujfalusi authored
When looking up the clock we must use the client->dev as device since that is the one which is probed via DT. Cc: stable@vger.kernel.org # 4.16+ Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by:
-
Sebastian Reichel authored
This adds the DT binding for the audio-codec sub-module found inside the Motorola CPCAP PMIC. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.co.uk> Acked-by:
Mark Brown <broonie@kernel.org> Acked-by:
-
Chen-Yu Tsai authored
When AXP806 support was added, POK was incorrectly expanded to PWROK. However, the datasheet lists them as POK[LSNP], which is the same as on the AXP288. Furthermore, the registers associated with POK functions are the same as the PEK on the other AXP PMICs. This suggests that "POK" means "Power On Key", much like "PEK" means "Power Enable Key", instead of "Power OK". This patch changes the "PWROK" prefix to "POK" for these interrupts. Signed-off-by:
Chen-Yu Tsai <wens@csie.org> Signed-off-by:
-
Chen-Yu Tsai authored
Previously we were open coding the interrupts for the various mfd cells. This made the code somewhat long due to pretty-formatting. This patch convert those into one-line declarations with DEFINE_RES_IRQ, making the code shorter and easier to read. Signed-off-by:
-
Chen-Yu Tsai authored
The axp20x driver has lots of mfd_cell and resource structs. These can all be const-ified. Signed-off-by:
-
Steve Twiss authored
Replace multi-line entries in the regmap_range arrays with single line macros: regmap_reg_range(). This will leave the static structure array entries for regmap_range unaltered. It will significantly reduce the line count in the DA9062/61 core file. Signed-off-by:
Steve Twiss <stwiss.opensource@diasemi.com> Signed-off-by:
-
Charles Keepax authored
Now GPIOD has support for both pdata systems and for non-standard DT bindings the Arizona reset GPIO can be converted to use it. Worth noting gpiod_set_raw_value_cansleep is used to match the behaviour of the old GPIOs. This is because the part is fairly widely used and it is unknown how many DTs are correctly setting active low through device tree, so to avoid breaking any existing users it is best to match the previous behaviour. Signed-off-by:
-
Baolin Wang authored
There are some global registers in Spreadtrum sc27xx PMICs, which will be accessed by other drivers. So this patch adds one syscon cell to help to access the PMIC's global registers. Signed-off-by:
Baolin Wang <baolin.wang@linaro.org> Signed-off-by:
-
Christophe JAILLET authored
If a 'platform_device_alloc()' call fails, we still need to release the resources that have already been allocated before returning. Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by:
-
Markus Elfring authored
Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by:
Markus Elfring <elfring@users.sourceforge.net> Signed-off-by:
-
Markus Elfring authored
Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by:
-
Markus Elfring authored
Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by:
-
Markus Elfring authored
Move the assignment for the local variable "dev" so that its setting will be performed after a configuration check by this function. Signed-off-by:
-
Markus Elfring authored
The local variable "dev" will be reassigned by a following statement. Thus omit the explicit initialisation at the beginning. Signed-off-by:
-
