- Aug 22, 2012
-
-
Xiao Guangrong authored
In current code, if we map a readonly memory space from host to guest and the page is not currently mapped in the host, we will get a fault pfn and async is not allowed, then the vm will crash We introduce readonly memory region to map ROM/ROMD to the guest, read access is happy for readonly memslot, write access on readonly memslot will cause KVM_EXIT_MMIO exit Signed-off-by:
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> Signed-off-by:
Avi Kivity <avi@redhat.com>
-
Xiao Guangrong authored
In the later patch, it indicates failure when we try to get a writable hva from the readonly memslot Signed-off-by:
-
Xiao Guangrong authored
Then, remove bad_hva and inline kvm_is_error_hva Signed-off-by:
-
Xiao Guangrong authored
In the later patch, it indicates failure when we try to get a writable pfn from the readonly memslot Signed-off-by:
-
Xiao Guangrong authored
In current code, we always map writable pfn for the read fault, in order to support readonly memslot, we map writable pfn only if 'writable' is not NULL Signed-off-by:
-
Xiao Guangrong authored
We do too many things in hva_to_pfn, this patch reorganize the code, let it be better readable Signed-off-by:
-
Xiao Guangrong authored
This set of functions is only used to read data from host space, in the later patch, we will only get a readonly hva in gfn_to_hva_read, and the function name is a good hint to let gfn_to_hva_read to pair with kvm_read_hva()/kvm_read_hva_atomic() Signed-off-by:
-
Xiao Guangrong authored
It can instead of hva_to_pfn_atomic Signed-off-by:
-
Xiao Guangrong authored
Quote Avi's comment: | KVM_MEMSLOT_INVALID is actually an internal symbol, not used by | userspace. Please move it to kvm_host.h. Also, we divide the memlsot->flags into two parts, the lower 16 bits are visible for userspace, the higher 16 bits are internally used in kvm Signed-off-by:
-
Xiao Guangrong authored
Check flags when memslot is registered from userspace as Avi's suggestion Signed-off-by:
-
Xiao Guangrong authored
Currently, we reexecute all unhandleable instructions if they do not access on the mmio, however, it can not work if host map the readonly memory to guest. If the instruction try to write this kind of memory, it will fault again when guest retry it, then we will goto a infinite loop: retry instruction -> write #PF -> emulation fail -> retry instruction -> ... Fix it by retrying the instruction only when it faults on the writable memory Signed-off-by:
-
- Aug 15, 2012
-
-
Florian Westphal authored
else, host continues to update stealtime after reboot, which can corrupt e.g. initramfs area. found when tracking down initramfs unpack error on initial reboot (with qemu-kvm -smp 2, no problem with single-core). Signed-off-by:
Florian Westphal <fw@strlen.de> Signed-off-by:
Marcelo Tosatti <mtosatti@redhat.com>
-
Michael S. Tsirkin authored
We validate irq pin number when routing is setup, so code handling illegal irq # in pic and ioapic on each injection is never called. Drop it, replace with BUG_ON to catch out of bounds access bugs. Signed-off-by:
Michael S. Tsirkin <mst@redhat.com> Signed-off-by:
-
- Aug 13, 2012
-
-
Avi Kivity authored
All processors that support VMX have that feature, and guests (Xen) depend on it. As we already implement it, advertize it to the guest. Signed-off-by:
-
Gleb Natapov authored
MSR_IA32_DEBUGCTLMSR is zeroed on VMEXIT. Restore it to the correct value. Signed-off-by:
Gleb Natapov <gleb@redhat.com> Signed-off-by:
-
Alexander Graf authored
Signed-off-by:
Alexander Graf <agraf@suse.de> Signed-off-by:
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com> Signed-off-by:
-
Raghavendra K T authored
Signed-off-by:
-
Raghavendra K T authored
Thanks Alex for KVM_HC_FEATURES inputs and Jan for VAPIC_POLL_IRQ, and Peter (HPA) for suggesting hypercall ABI addition. Signed-off-by:
-
Marcelo Tosatti authored
kvm_guest_time_update unconditionally clears hv_clock.flags field, so the notification never reaches the guest. Fix it by allowing PVCLOCK_GUEST_STOPPED to passthrough. Reviewed-by:
Eric B Munson <emunson@mgebm.net> Reviewed-by:
Amit Shah <amit.shah@redhat.com> Signed-off-by:
-
- Aug 09, 2012
-
-
Gleb Natapov authored
For apic_set_spiv() to track APIC SW state correctly it needs to see previous and next values of the spurious vector register, but currently memset() overwrite the old value before apic_set_spiv() get a chance to do tracking. Fix it by calling apic_set_spiv() before overwriting old value. Signed-off-by:
-
- Aug 06, 2012
-
-
Gleb Natapov authored
Those functions are used during interrupt injection. When inlined they become nops on the fast path. Signed-off-by:
-
Gleb Natapov authored
Usually all vcpus have local apic pointer initialized, so the check may be completely skipped. Signed-off-by:
-
Gleb Natapov authored
Usually all APICs are SW enabled so the check can be optimized out. Signed-off-by:
-
Gleb Natapov authored
Usually all APICs are HW enabled so the check can be optimized out. Signed-off-by:
-
Gleb Natapov authored
CC: Jason Baron <jbaron@redhat.com> CC: Ingo Molnar <mingo@elte.hu> CC: Peter Zijlstra <a.p.zijlstra@chello.nl> Signed-off-by:
Jason Baron <jbaron@redhat.com> Signed-off-by:
-
Gleb Natapov authored
According to SDM apic is enabled on start up. Signed-off-by:
-
Gleb Natapov authored
Do not change apic_base directly. Use kvm_lapic_set_base() instead. Signed-off-by:
-
Gleb Natapov authored
kvm_get_apic_base() needlessly checks irqchip_in_kernel although it does the same no matter what result of the check is. kvm_set_apic_base() also checks for irqchip_in_kernel, but kvm_lapic_set_base() can handle this case. Signed-off-by:
-
Xiao Guangrong authored
Currently, we use the error code as error pfn to indicat the error condition, it is not straightforward and it will not work on PAE 32-bit cpu with huge memory, since the valid physical address can be at most 52 bits For the normal pfn, the highest 12 bits should be zero, so we can mask these bits to indicate the error. Signed-off-by:
-
Xiao Guangrong authored
After commit a2766325, the error page is replaced by the error code, it need not be released anymore [ The patch has been compiling tested for powerpc ] Signed-off-by:
-
Xiao Guangrong authored
After commit a2766325, the error pfn is replaced by the error code, it need not be released anymore [ The patch has been compiling tested for powerpc ] Signed-off-by:
-
Xiao Guangrong authored
It is used to eliminate the overload of function call and cleanup the code Signed-off-by:
-
Xiao Guangrong authored
Remove it since it is not used anymore Signed-off-by:
-
Xiao Guangrong authored
These functions are exported and can not inline, move them to kvm_host.h to eliminate the overload of function call Signed-off-by:
-
Xiao Guangrong authored
Then, remove get_bad_pfn Signed-off-by:
-
Xiao Guangrong authored
Then, get_hwpoison_pfn and is_hwpoison_pfn can be removed Signed-off-by:
-
Xiao Guangrong authored
After that, the exported and un-inline function, get_fault_pfn, can be removed Signed-off-by:
-
Xiao Guangrong authored
There are two bugs: - the 'error page' is forgot to be released [ it is unneeded after commit a2766325, for backport, we still do kvm_release_pfn_clean for the error pfn ] - guest pages are always released regardless of the unmapped page (e,g, caused by hwpoison) Signed-off-by:
-
Takuya Yoshikawa authored
Two reasons: - x86 can integrate rmap and rmap_pde and remove heuristics in __gfn_to_rmap(). - Some architectures do not need rmap. Since rmap is one of the most memory consuming stuff in KVM, ppc'd better restrict the allocation to Book3S HV. Signed-off-by:
Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp> Acked-by:
Paul Mackerras <paulus@samba.org> Signed-off-by:
-
Takuya Yoshikawa authored
This helps to make rmap architecture specific in a later patch. Signed-off-by:
-
