Skip to content
  1. Apr 15, 2022
  2. Mar 29, 2022
    • Anton Eidelman's avatar
      nvme-multipath: fix hang when disk goes live over reconnect · a4a6f3c8
      Anton Eidelman authored
      
      
      nvme_mpath_init_identify() invoked from nvme_init_identify() fetches a
      fresh ANA log from the ctrl.  This is essential to have an up to date
      path states for both existing namespaces and for those scan_work may
      discover once the ctrl is up.
      
      This happens in the following cases:
        1) A new ctrl is being connected.
        2) An existing ctrl is successfully reconnected.
        3) An existing ctrl is being reset.
      
      While in (1) ctrl->namespaces is empty, (2 & 3) may have namespaces, and
      nvme_read_ana_log() may call nvme_update_ns_ana_state().
      
      This result in a hang when the ANA state of an existing namespace changes
      and makes the disk live: nvme_mpath_set_live() issues IO to the namespace
      through the ctrl, which does NOT have IO queues yet.
      
      See sample hang below.
      
      Solution:
      - nvme_update_ns_ana_state() to call set_live only if ctrl is live
      - nvme_read_ana_log() call from nvme_mpath_init_identify()
        therefore only fetches and parses the ANA log;
        any erros in this process will fail the ctrl setup as appropriate;
      - a separate function nvme_mpath_update()
        is called in nvme_start_ctrl();
        this parses the ANA log without fetching it.
        At this point the ctrl is live,
        therefore, disks can be set live normally.
      
      Sample failure:
          nvme nvme0: starting error recovery
          nvme nvme0: Reconnecting in 10 seconds...
          block nvme0n6: no usable path - requeuing I/O
          INFO: task kworker/u8:3:312 blocked for more than 122 seconds.
                Tainted: G            E     5.14.5-1.el7.elrepo.x86_64 #1
          Workqueue: nvme-wq nvme_tcp_reconnect_ctrl_work [nvme_tcp]
          Call Trace:
           __schedule+0x2a2/0x7e0
           schedule+0x4e/0xb0
           io_schedule+0x16/0x40
           wait_on_page_bit_common+0x15c/0x3e0
           do_read_cache_page+0x1e0/0x410
           read_cache_page+0x12/0x20
           read_part_sector+0x46/0x100
           read_lba+0x121/0x240
           efi_partition+0x1d2/0x6a0
           bdev_disk_changed.part.0+0x1df/0x430
           bdev_disk_changed+0x18/0x20
           blkdev_get_whole+0x77/0xe0
           blkdev_get_by_dev+0xd2/0x3a0
           __device_add_disk+0x1ed/0x310
           device_add_disk+0x13/0x20
           nvme_mpath_set_live+0x138/0x1b0 [nvme_core]
           nvme_update_ns_ana_state+0x2b/0x30 [nvme_core]
           nvme_update_ana_state+0xca/0xe0 [nvme_core]
           nvme_parse_ana_log+0xac/0x170 [nvme_core]
           nvme_read_ana_log+0x7d/0xe0 [nvme_core]
           nvme_mpath_init_identify+0x105/0x150 [nvme_core]
           nvme_init_identify+0x2df/0x4d0 [nvme_core]
           nvme_init_ctrl_finish+0x8d/0x3b0 [nvme_core]
           nvme_tcp_setup_ctrl+0x337/0x390 [nvme_tcp]
           nvme_tcp_reconnect_ctrl_work+0x24/0x40 [nvme_tcp]
           process_one_work+0x1bd/0x360
           worker_thread+0x50/0x3d0
      
      Signed-off-by: default avatarAnton Eidelman <anton@lightbitslabs.com>
      Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      a4a6f3c8
    • Chris Leech's avatar
      nvme: fix RCU hole that allowed for endless looping in multipath round robin · d6d67427
      Chris Leech authored
      
      
      Make nvme_ns_remove match the assumptions elsewhere.
      
      1) !NVME_NS_READY needs to be srcu synchronized to make sure nothing is
         running in __nvme_find_path or nvme_round_robin_path that will
         re-assign this ns to current_path.
      
      2) Any matching current_path entries need to be cleared before removing
         from the siblings list, to prevent calling nvme_round_robin_path with
         an "old" ns that's off list.
      
      3) Finally the list_del_rcu can happen, and then synchronize again
         before releasing any reference counts.
      
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      d6d67427
    • Sungup Moon's avatar
      nvme: allow duplicate NSIDs for private namespaces · 5974ea7c
      Sungup Moon authored
      
      
      A NVMe subsystem with multiple controller can have private namespaces
      that use the same NSID under some conditions:
      
       "If Namespace Management, ANA Reporting, or NVM Sets are supported, the
        NSIDs shall be unique within the NVM subsystem. If the Namespace
        Management, ANA Reporting, and NVM Sets are not supported, then NSIDs:
         a) for shared namespace shall be unique; and
         b) for private namespace are not required to be unique."
      
      Reference: Section 6.1.6 NSID and Namespace Usage; NVM Express 1.4c spec.
      
      Make sure this specific setup is supported in Linux.
      
      Fixes: 9ad1927a ("nvme: always search for namespace head")
      Signed-off-by: default avatarSungup Moon <sungup.moon@samsung.com>
      [hch: refactored and fixed the controller vs subsystem based naming
            conflict]
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
      5974ea7c
    • Colin Ian King's avatar
      nvmet: remove redundant assignment after left shift · 63bc732c
      Colin Ian King authored
      
      
      The left shift is followed by a re-assignment back to cc_css, the
      assignment is redundant.  Fix this by replacing the "<<=" operator with
      "<<" instead.
      
      This cleans up the clang scan build warning:
      
      drivers/nvme/target/core.c:1124:10: warning: Although the value stored to 'cc_css' is used in the enclosing expression, the value is never actually read from 'cc_css' [deadcode.DeadStores]
      
      Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
      Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
      Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
      Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      63bc732c
    • Sagi Grimberg's avatar
      nvmet: use a private workqueue instead of the system workqueue · 8832cf92
      Sagi Grimberg authored
      
      
      Any attempt to flush kernel-global WQs has possibility of deadlock
      so we should simply stop using them, instead introduce nvmet_wq
      which is the generic nvmet workqueue for work elements that
      don't explicitly require a dedicated workqueue (by the mere fact
      that they are using the system_wq).
      
      Changes were done using the following replaces:
      
       - s/schedule_work(/queue_work(nvmet_wq, /g
       - s/schedule_delayed_work(/queue_delayed_work(nvmet_wq, /g
       - s/flush_scheduled_work()/flush_workqueue(nvmet_wq)/g
      
      Reported-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
      Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
      Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      8832cf92
  3. Mar 23, 2022
  4. Mar 16, 2022
  5. Mar 15, 2022
  6. Mar 14, 2022
  7. Mar 07, 2022
  8. Mar 03, 2022
  9. Feb 28, 2022
Loading