- Dec 06, 2006
-
-
Trond Myklebust authored
This will ensure that we can call set_page_writeback() from within nfs_writepage(), which is always called with the page lock set. Signed-off-by:Trond Myklebust <Trond.Myklebust@netapp.com>
-
Trond Myklebust authored
Signed-off-by: -
Trond Myklebust authored
We will want to allow nfs_writepage() to distinguish between pages that have been marked as dirty by the VM, and those that have been marked as dirty by nfs_updatepage(). In the former case, the entire page will want to be written out, and so any requests that were pending need to be flushed out first. Signed-off-by: -
Trond Myklebust authored
Maintaining two parallel ways of doing synchronous writes is rather pointless. This patch gets rid of the legacy nfs_writepage_sync(), and replaces it with the faster asynchronous writes. Signed-off-by: -
Trond Myklebust authored
Signed-off-by: -
Trond Myklebust authored
We always ensure that the nfs_open_context holds a reference to the dentry, so the test in nfs_writepage() for whether or not the inode is referenced is redundant. Signed-off-by: -
Trond Myklebust authored
Clean up a lot of ad-hoc page length calculations in fs/nfs/write.c Signed-off-by: -
Trond Myklebust authored
This will allow fast lookup of the nfs_page from the struct page instead of having to search the radix tree. Signed-off-by: -
Trond Myklebust authored
Allow callers to directly pass it a struct writeback_control. Signed-off-by: -
Trond Myklebust authored
Pass down struct writeback control. Signed-off-by: -
Trond Myklebust authored
Make it take a struct writepages argument, and rename to nfs_flush_mapping(). Signed-off-by: -
Frank Filz authored
Remove use of the Big Kernel Lock around indirect calls to nfs3_proc_readlink and nfs4_proc_readlink, both of which basically call rpc_call_sync. Signed-off-by:
Frank Filz <ffilz@us.ibm.com> Signed-off-by:
-
Frank Filz authored
Remove use of the Big Kernel Lock around calls to rpc_call_sync. Signed-off-by:
-
Frank Filz authored
Remove use of the Big Kernel Lock around calls to rpc_execute. Signed-off-by:
-
Trond Myklebust authored
Currently nfs_sync_inode_wait() will fail to loop correctly when we call nfs_sync_inode_wait with the FLUSH_INVALIDATE argument. Signed-off-by: -
Trond Myklebust authored
Signed-off-by: -
Trond Myklebust authored
We must always call ->read_done() before we truncate the page data, or decide to flag an error. The reasons are that in NFSv2, ->read_done() is where the eof flag gets set. in NFSv3/v4 ->read_done() handles EJUKEBOX-type errors, and v4 state recovery. However, we need to mark the pages as uptodate before we deal with short read errors, since we may need to modify the nfs_read_data arguments. We therefore split the current nfs_readpage_result() into two parts: nfs_readpage_result(), which calls ->read_done() etc, and nfs_readpage_retry(), which subsequently handles short reads. Note: Removing the code that retries in case of a short read also fixes a bug in nfs_direct_read_result(), which used to return a corrupted number of bytes. Signed-off-by: -
Andy Ryan authored
When trying to open a file with the O_EXCL flag over NFS on a server that does not support exclusive mode, the file does not open. The reason, rpc_call_sync returns a errno number, and not the nfs error number. I fixed it by changing the status check in nfs3proc.c. Either this is how it should be fixed, or rpc_call_sync should be fixed to return the NFS error. Signed-off-by:
Andy Ryan <genanr@allantgroup.com> Signed-off-by:
-
Trond Myklebust authored
Use RCU to ensure that we can safely call rpc_finish_wakeup after we've called __rpc_do_wake_up_task. If not, there is a theoretical race, in which the rpc_task finishes executing, and gets freed first. Signed-off-by: -
Trond Myklebust authored
Signed-off-by:
-
- Dec 03, 2006
-
-
Al Viro authored
Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Nov 06, 2006
-
-
Eric W. Biederman authored
This patch takes the CTL_UNNUMBERD concept from NFS and makes it available to all new sysctl users. At the same time the sysctl binary interface maintenance documentation is updated to mention and to describe what is needed to successfully maintain the sysctl binary interface. Signed-off-by:
Eric W. Biederman <ebiederm@xmission.com> Acked-by:
Alan Cox <alan@redhat.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
- Oct 21, 2006
-
-
Trond Myklebust authored
If someone has renamed a directory on the server, triggering the d_move code in d_materialise_unique(), then we need to invalidate the cached directory information in the source parent directory. Signed-off-by:
-
Trond Myklebust authored
If the caller tries to instantiate a directory using an inode that already has a dentry alias, then we attempt to rename the existing dentry instead of instantiating a new one. Fail with an ELOOP error if the rename would affect one of our parent directories. This behaviour is needed in order to avoid issues such as http://bugzilla.kernel.org/show_bug.cgi?id=7178 Signed-off-by:
-
- Oct 20, 2006
-
-
Al Viro authored
[pulled from Alexey's patch] Signed-off-by:
Trond Myklebust <trond.myklebust@fys.uio.no> Acked-by:
Neil Brown <neilb@suse.de> Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
on-the-wire data is big-endian [mostly pulled from Alexey's patch] Signed-off-by:
-
Al Viro authored
[pulled from Alexey's patch] Signed-off-by:
-
Al Viro authored
on-the-wire data is big-endian [in large part pulled from Alexey's patch] Signed-off-by:
-
Al Viro authored
on-the-wire data is big-endian [in large part pulled from Alexey's patch] Signed-off-by:
-
Al Viro authored
on-the-wire data is big-endian [in large part pulled from Alexey's patch] Signed-off-by:
-
Al Viro authored
on-the-wire data is big-endian [in large part pulled from Alexey's patch] Signed-off-by:
-
Al Viro authored
svc_procfunc instances return __be32, not int Signed-off-by:
-
Chuck Lever authored
Coverity spotted a superfluous error check in nfs4_open_revalidate(). Remove it. Coverity: #cid 847 Test plan: Code inspection; another pass through Coverity. Signed-off-by:
Chuck Lever <chuck.lever@oracle.com> Signed-off-by:
-
Chuck Lever authored
The "!inode" check in __nfs_revalidate_inode() occurs well after the first time it is dereferenced, so get rid of it. Coverity: #cid 1372, 1373 Test plan: Code review; recheck with Coverity. Signed-off-by:
-
Chuck Lever authored
The original code confused a zero return code from pagevec_add() as success. Test plan: None. Signed-off-by:
-
Trond Myklebust authored
If invalidate_inode_pages2() fails, then it should in principle just be because the current process was signalled. In that case, we just want to ensure that the inode's page cache remains marked as invalid. Also add a helper to allow the O_DIRECT code to simply mark the page cache as invalid once it is finished writing, instead of calling invalidate_inode_pages2() itself. Signed-off-by:
-
Trond Myklebust authored
The change in semantics for nfs_find_client() introduced by David breaks the NFSv4 callback channel. Also, replace another completely broken BUG_ON() in nfs_find_client(). In initialised clients, clp->cl_cons_state == 0, and callers of that function should in any case never want to see clients that are uninitialised. Signed-off-by:
-
J. Bruce Fields authored
David forgot to do this. I'm not sure if this is the right place to put it.... Signed-off-by:
J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by:
-
Trond Myklebust authored
If the RPC call tanked, we should not be checking the return value of data->res.verf->committed, since it is unlikely to even be initialised. Signed-off-by:
-
